Skip to content

Commit 80d502e

Browse files
authored
fix: fixes log parser (#3398)
1 parent 56a2ab1 commit 80d502e

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

internal/docker/logfmt.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ func ParseLogFmt(log string) (*orderedmap.OrderedMap[string, string], error) {
1717
char := log[i]
1818
if isKey {
1919
if char == '=' {
20-
if i == start {
20+
if start >= i {
2121
return nil, errors.New("invalid format: key is empty")
2222
}
2323
key = log[start:i]

internal/docker/logfmt_test.go

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,12 @@ func TestParseLog(t *testing.T) {
6767
),
6868
wantErr: false,
6969
},
70+
{
71+
name: "Broken format with unexpected quotes",
72+
log: `key1=value"1"= key2="value2"`,
73+
want: nil,
74+
wantErr: true,
75+
},
7076
{
7177
name: "Invalid log with unclosed quotes",
7278
log: "key1=\"value1 key2=value2",

0 commit comments

Comments
 (0)