Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds a side panel for complex logs that enables reordering and enabling fields #3237

Merged
merged 25 commits into from
Aug 29, 2024

Conversation

amir20
Copy link
Owner

@amir20 amir20 commented Aug 27, 2024

Screenshot 2024-08-27 at 11 26 30 AM

@amir20 amir20 changed the title panel feat: adds a side panel for complex logs that enables reordering and enabling fields Aug 27, 2024
@amir20 amir20 enabled auto-merge (squash) August 29, 2024 00:29
@amir20
Copy link
Owner Author

amir20 commented Aug 29, 2024

@FrancYescO I saw you reacted on this PR. I am merging it soon. I think it is the last thing I want to do before releasing. Could you test master?

@amir20 amir20 merged commit 85271a5 into master Aug 29, 2024
6 checks passed
@amir20 amir20 deleted the panel branch August 29, 2024 00:37
@FrancYescO
Copy link

FrancYescO commented Aug 29, 2024

just got a glitch: if a value is pretty long with no spaces will not wrap text and will hide the togglebox (will go on the left out of screen and you need to horizontal scroll to show)

@FrancYescO
Copy link

also consider adding a label "drag to reorder" or some icon that will show the cross cursor, otherwise will be a very hidden feature

@FrancYescO
Copy link

FrancYescO commented Aug 29, 2024

maybe in the time on top of the sidebar you can add also the ms of the log datetime, and idk if is and easy add also a toggle for the specific log level (but than i have some doubt on how this can be toggled back to be visualized)

@amir20
Copy link
Owner Author

amir20 commented Aug 29, 2024

Thanks @FrancYescO

Yea there are some horizontal spaces that need to be improved. And even more on mobile.

also consider adding a label "drag to reorder" or some icon that will show the cross cursor, otherwise will be a very hidden feature

Doesn't the cursor already change to a cross? Or do you mean additionally put a note about it?

and idk if is and easy add also a toggle for the specific log level (but than i have some doubt on how this can be toggled back to be visualized)

What does this mean? Do you mean filter by log levels? #2432

@FrancYescO
Copy link

Yes but it changes only while dragging, there is no indication that you are allowed to drag 😃

And yes i was referencing to the same feature of the #2432

renovate bot referenced this pull request in NorkzYT/Wolflith Sep 2, 2024
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [amir20/dozzle](https://togithub.com/amir20/dozzle) | minor | `v8.2.1`
-> `v8.3.0` |

---

### Release Notes

<details>
<summary>amir20/dozzle (amir20/dozzle)</summary>

### [`v8.3.0`](https://togithub.com/amir20/dozzle/releases/tag/v8.3.0)

[Compare
Source](https://togithub.com/amir20/dozzle/compare/v8.2.1...v8.3.0)

#####    🚀 Features

- Retries to fetch more logs if no logs are fetched when scrolling up
 -  by [@&#8203;amir20](https://togithub.com/amir20) in
[https://github.com/amir20/dozzle/issues/3230](https://togithub.com/amir20/dozzle/issues/3230)
[<samp>(afcb8)</samp>](https://togithub.com/amir20/dozzle/commit/afcb8093)
- Adds animations to bottom when in live mode  -  by
[@&#8203;amir20](https://togithub.com/amir20) in
[https://github.com/amir20/dozzle/issues/3231](https://togithub.com/amir20/dozzle/issues/3231)
[<samp>(aec81)</samp>](https://togithub.com/amir20/dozzle/commit/aec8139a)
- Changes scroll progress to reflect total available logs instead of
just the logs in the browser  -  by
[@&#8203;amir20](https://togithub.com/amir20) in
[https://github.com/amir20/dozzle/issues/3236](https://togithub.com/amir20/dozzle/issues/3236)
[<samp>(0a039)</samp>](https://togithub.com/amir20/dozzle/commit/0a039235)
- Adds a side panel for complex logs that enables reordering and
enabling fields  -  by [@&#8203;amir20](https://togithub.com/amir20) in
[https://github.com/amir20/dozzle/issues/3237](https://togithub.com/amir20/dozzle/issues/3237)
[<samp>(85271)</samp>](https://togithub.com/amir20/dozzle/commit/85271a59)
- Show version number on top right. see
[#&#8203;3228](https://togithub.com/amir20/dozzle/issues/3228)  -  by
[@&#8203;amir20](https://togithub.com/amir20) in
[https://github.com/amir20/dozzle/issues/3239](https://togithub.com/amir20/dozzle/issues/3239)
and
[https://github.com/amir20/dozzle/issues/3228](https://togithub.com/amir20/dozzle/issues/3228)
[<samp>(9ea70)</samp>](https://togithub.com/amir20/dozzle/commit/9ea7024c)

#####    🐞 Bug Fixes

- Fixes settings page when changing language  -  by
[@&#8203;amir20](https://togithub.com/amir20) in
[https://github.com/amir20/dozzle/issues/3216](https://togithub.com/amir20/dozzle/issues/3216)
[<samp>(43194)</samp>](https://togithub.com/amir20/dozzle/commit/4319415e)
- Host port nb typo in readme  -  by
[@&#8203;Qhilm](https://togithub.com/Qhilm) in
[https://github.com/amir20/dozzle/issues/3220](https://togithub.com/amir20/dozzle/issues/3220)
[<samp>(eaf20)</samp>](https://togithub.com/amir20/dozzle/commit/eaf20059)
- Fixes infinite loop when there are no logs  -  by
[@&#8203;amir20](https://togithub.com/amir20) in
[https://github.com/amir20/dozzle/issues/3235](https://togithub.com/amir20/dozzle/issues/3235)
[<samp>(3a0ea)</samp>](https://togithub.com/amir20/dozzle/commit/3a0eaf16)
- Fixes broken skip logs  -  by
[@&#8203;amir20](https://togithub.com/amir20)
[<samp>(0798d)</samp>](https://togithub.com/amir20/dozzle/commit/0798de3b)
-   **deps**:
- Update all non-major dependencies  -  in
[https://github.com/amir20/dozzle/issues/3209](https://togithub.com/amir20/dozzle/issues/3209)
[<samp>(9f743)</samp>](https://togithub.com/amir20/dozzle/commit/9f743132)
- Update dependency
[@&#8203;vueuse/core](https://togithub.com/vueuse/core) to v11  -  in
[https://github.com/amir20/dozzle/issues/3211](https://togithub.com/amir20/dozzle/issues/3211)
[<samp>(acd99)</samp>](https://togithub.com/amir20/dozzle/commit/acd9946b)
- Update dependency
[@&#8203;vueuse/components](https://togithub.com/vueuse/components) to
v11  -  in
[https://github.com/amir20/dozzle/issues/3210](https://togithub.com/amir20/dozzle/issues/3210)
[<samp>(3d9e0)</samp>](https://togithub.com/amir20/dozzle/commit/3d9e025b)
- Update dependency
[@&#8203;vueuse/router](https://togithub.com/vueuse/router) to v11  - 
in
[https://github.com/amir20/dozzle/issues/3213](https://togithub.com/amir20/dozzle/issues/3213)
[<samp>(1dea4)</samp>](https://togithub.com/amir20/dozzle/commit/1dea4f10)
- Update dependency unplugin-vue-macros to ^2.11.6  -  in
[https://github.com/amir20/dozzle/issues/3215](https://togithub.com/amir20/dozzle/issues/3215)
[<samp>(b5461)</samp>](https://togithub.com/amir20/dozzle/commit/b54611fb)
- Update all non-major dependencies  -  in
[https://github.com/amir20/dozzle/issues/3232](https://togithub.com/amir20/dozzle/issues/3232)
[<samp>(4bb00)</samp>](https://togithub.com/amir20/dozzle/commit/4bb007fd)
- Update all non-major dependencies  -  in
[https://github.com/amir20/dozzle/issues/3238](https://togithub.com/amir20/dozzle/issues/3238)
[<samp>(62a2e)</samp>](https://togithub.com/amir20/dozzle/commit/62a2ef9e)

#####    🏎 Performance

- Tries to improve burst of logs  -  by
[@&#8203;amir20](https://togithub.com/amir20) in
[https://github.com/amir20/dozzle/issues/3227](https://togithub.com/amir20/dozzle/issues/3227)
[<samp>(36f33)</samp>](https://togithub.com/amir20/dozzle/commit/36f3308e)

#####     [View changes on
GitHub](https://togithub.com/amir20/dozzle/compare/v8.2.1...v8.3.0)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 10pm every weekday,every
weekend,before 5am every weekday" in timezone America/New_York,
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/NorkzYT/Wolflith).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41Ni4wIiwidXBkYXRlZEluVmVyIjoiMzguNTYuMCIsInRhcmdldEJyYW5jaCI6InN0YWdpbmciLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIiwibWlub3IiLCJyZW5vdmF0ZSJdfQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@redge76
Copy link

redge76 commented Sep 2, 2024

It's an interesting feature but when there is a LOT OF fields (like the access log of traefik) then if is impossible to see all fields on one page (and I'm on a 32" monitor...)
Previously you cloud click on a line and get all the fields concatenated. It was hard to read but at least you could see everything without scrolling too much.
I don't know what would make a good solution to this issue. Maybe a tooltip with a condensed line as previously.

@amir20
Copy link
Owner Author

amir20 commented Sep 2, 2024

Screenshot?

@redge76
Copy link

redge76 commented Sep 2, 2024

There is not much to see. The traefik access log had 40 fields. if you enable a few and click on a line you get this:
image

Previously when you clicked on a line you had the same result you have now when you select all fields (where you could select the fields you wanted to display)

@amir20
Copy link
Owner Author

amir20 commented Sep 2, 2024

I don't understand what you are saying is not possible now. If it's a bug then open an issue with better description. I have read your comment a few times and can't make any sense of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants