Skip to content

fix: dont re-add plugin; remove integration timout error log #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 1, 2025
Merged

fix: dont re-add plugin; remove integration timout error log #173

merged 2 commits into from
Apr 1, 2025

Conversation

@bgiori
Copy link
Collaborator

@bgiori bgiori commented Apr 1, 2025

Summary

  • Refactor the factory functions to only init and add the plugin when a singleton instance does not already exist.
  • Remove error log on integration timeout because unified script calls this function for web experiment.

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: no

@bgiori bgiori merged commit 9490d83 into main Apr 1, 2025
6 checks passed
@bgiori bgiori deleted the refactor-factory-remove-log branch April 1, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@bgiori