fix: do not treat falsy values like 0 and false as undefined #220
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
My earlier fix (#143 ) was not complete. This removes remaining instances of early returns when a property value evaluates to false. This allows to correctly evaluate comparisons like
0==0or0<1orfalse=false.However, we need to make sure that this isn't expected behavior for some use cases. Atm, comparing the
(none)value that you can select in the conditions builder to number value0or boolean valuefalsewould evaluate totruewhich changes with this PR.Checklist