Skip to content

Conversation

@tkainrad
Copy link
Contributor

@tkainrad tkainrad commented Oct 1, 2025

Summary

My earlier fix (#143 ) was not complete. This removes remaining instances of early returns when a property value evaluates to false. This allows to correctly evaluate comparisons like 0==0 or 0<1 or false=false.

However, we need to make sure that this isn't expected behavior for some use cases. Atm, comparing the (none) value that you can select in the conditions builder to number value 0 or boolean value false would evaluate to true which changes with this PR.

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?:

@tkainrad tkainrad requested a review from bgiori October 1, 2025 08:32
@tyiuhc
Copy link
Collaborator

tyiuhc commented Oct 1, 2025

@tkainrad I agree that this is the correct evaluation logic, but just concerned that it may break existing customer implementation. @bgiori any thoughts?

@bgiori
Copy link
Collaborator

bgiori commented Oct 2, 2025

@tkainrad I agree that this is the correct evaluation logic, but just concerned that it may break existing customer implementation. @bgiori any thoughts?

Consistency across platforms trumps consistency for a single platform

@tkainrad tkainrad merged commit 17d8548 into main Oct 2, 2025
7 of 10 checks passed
@tkainrad tkainrad deleted the thomas.kainrad/SKY-8749 branch October 2, 2025 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants