Skip to content

feat: add clear method to clear flag configs #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 18, 2022
Merged

feat: add clear method to clear flag configs #51

merged 3 commits into from
Oct 18, 2022

Conversation

@yuhao900914
Copy link
Contributor

Summary

Add functionality for manipulating the flag config cache

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?:

qingzhuozhen
qingzhuozhen approved these changes Oct 15, 2022
View reviewed changes
Copy link

@qingzhuozhen qingzhuozhen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

bgiori
bgiori approved these changes Oct 15, 2022
View reviewed changes
@yuhao900914 yuhao900914 merged commit ceddb50 into main Oct 18, 2022
@yuhao900914 yuhao900914 deleted the clear branch October 18, 2022 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bgiori bgiori bgiori approved these changes

+1 more reviewer

@qingzhuozhen qingzhuozhen qingzhuozhen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yuhao900914 @bgiori @qingzhuozhen