Skip to content

feat: sub flag key config support #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 14, 2022
Merged

feat: sub flag key config support #53

merged 2 commits into from
Nov 14, 2022

Conversation

@yuhao900914
Copy link
Contributor

Summary

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?:

qingzhuozhen
qingzhuozhen reviewed Oct 30, 2022
View reviewed changes
Copy link

@qingzhuozhen qingzhuozhen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg, maybe get the build pass later

@yuhao900914
Copy link
Contributor Author

lg, maybe get the build pass later

Yes, the current test only works for the local server. Need to fix the test until we deployed the skylab API.

bgiori
bgiori approved these changes Nov 4, 2022
View reviewed changes
Copy link
Collaborator

@bgiori bgiori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@yuhao900914 yuhao900914 requested a review from bgiori November 14, 2022 18:12
@yuhao900914 yuhao900914 merged commit ef9fdf6 into main Nov 14, 2022
@yuhao900914 yuhao900914 deleted the subFlag branch November 14, 2022 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bgiori bgiori Awaiting requested review from bgiori

1 more reviewer

@qingzhuozhen qingzhuozhen qingzhuozhen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yuhao900914 @bgiori @qingzhuozhen