Skip to content

fix: remove duplicated user agent parser from build #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 29, 2023
Merged

fix: remove duplicated user agent parser from build #74

merged 1 commit into from
Jun 29, 2023

Conversation

@kevinpagtakhan
Copy link
Contributor

Summary

Exclude @amplitude/ua-parser-js from bundle. This dependency will be installed by consumer and will be used by this package.

cc @stof

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: No

@kevinpagtakhan kevinpagtakhan requested review from a team and bgiori June 29, 2023 16:58
@kevinpagtakhan kevinpagtakhan self-assigned this Jun 29, 2023
@kevinpagtakhan kevinpagtakhan mentioned this pull request Jun 29, 2023
Merged
1 task
@kevinpagtakhan kevinpagtakhan merged commit c639c27 into main Jun 29, 2023
@kevinpagtakhan kevinpagtakhan deleted the AMP-74907-exclude-ua-parser-js branch June 29, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bgiori bgiori bgiori approved these changes

+1 more reviewer

@qingzhuozhen qingzhuozhen qingzhuozhen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kevinpagtakhan kevinpagtakhan

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kevinpagtakhan @bgiori @qingzhuozhen