Skip to content

Conversation

@bgiori
Copy link
Collaborator

@bgiori bgiori commented Sep 18, 2023

Summary

  • Call get() for accessing the variant rather than getAll()[key]
  • Check if there is a legacy exposure tracker before adding context to the user

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: No

@bgiori bgiori requested review from paladin8 and tyiuhc September 18, 2023 18:32
Copy link

@paladin8 paladin8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix! I assume we'll release a new version and then upgrade the client used in our app?

@bgiori
Copy link
Collaborator Author

bgiori commented Sep 18, 2023

Thanks for the quick fix! I assume we'll release a new version and then upgrade the client used in our app?

Yep, thanks for the review, and thanks again for finding this.

@bgiori bgiori merged commit bf40f9b into main Sep 18, 2023
@bgiori bgiori deleted the cache-optimziations branch September 18, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants