Carousel and slides migration #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| let minDelta = 0; | ||
| let maxDelta = 0; | ||
| let prevTr = tr.NULL; | ||
| let nextTr = tr.NULL; |
There was a problem hiding this comment.
any chance we can rename the NULL function into noop or NOOP since i was confused at first why we had a NULL sentinel of some sort.
There was a problem hiding this comment.
Great idea! Done.
|
/cc @cramforce. for any after review comments |
| this.pos_ = e.position; | ||
| this.commitSwitch_(e.startPosition, this.pos_, dir); | ||
| }); | ||
| this.setupGestures_(); |
There was a problem hiding this comment.
can we move the setupGestures_ call into BaseCarousel and add an interface to override.
|
just move |
dvoytenko
force-pushed
the
carousel-gestures
branch
from
bf7cba5 to
6cb7fda
Compare
dvoytenko
added a commit
that referenced
this pull request
Sep 30, 2015
Carousel and slides migration
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a big PR, but it's necessary. The main change is that the legacy SwipeX is replaced with new gestures. The gestures and motion are tuned up for responsiveness and smoothness.