apard32690 IP settings fixes #2176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case we want to use a static IP, the NO_OS_IP, NO_OS_NETMASK and NO_OS_GATEWAY variables have to be set before including generic.mk. Otherwise, the macros with the same name won't be defined in lwip.mk, thus the static IP settings will be ignored (resulting in trying to get an IP over DHCP). Fixes: b51e518 ("Allow for IP setting at compile time") Reported-by: Brandon Hurst <brandon.hurst@analog.com> Signed-off-by: Ciprian Regus <ciprian.regus@analog.com>
Configure the echo server project to use a static IP by default instead of using DHCP. This is done in order to allow easier evaluation, since most people would connect the board directly to their system (no DHCP server in between). Signed-off-by: Ciprian Regus <ciprian.regus@analog.com>
Update the README document in order to include that the IP settings are printed over the serial connection during the LWIP initialization. Signed-off-by: Brandon Hurst <brandon.hurst@analog.com> Signed-off-by: Ciprian Regus <ciprian.regus@analog.com>
Similarly to 18b5609 ("projects: swiot1l: Change default static IP "), change the default static IP for the echo server project version, since IPs in the 169.254.0.0/16 range shouldn't be assigned manually. Update the network mask variable and the documentation accordingly. Signed-off-by: Ciprian Regus <ciprian.regus@analog.com>
CiprianRegus
requested review from
buha,
dbogdan,
amiclaus,
rbolboac and
danmois
as code owners
rbolboac
previously approved these changes
May 7, 2024
10 tasks
Since both the apard32690 and swiot1l projects are now using the 192.168.97.40/16 IP by default, the user is required to manually configure an IP in the same network for their host's interface. Update the documentation to include the wiki guide on how to do this. Signed-off-by: Ciprian Regus <ciprian.regus@analog.com>
rbolboac
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Currently, there are some issues which cause the IP settings for the echo server project version to ignore the IP settings done in the makefile.
Related to #2172
PR Type
PR Checklist