-
-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrated ng-app from .analog to .ag extension #1456
feat: migrated ng-app from .analog to .ag extension #1456
Conversation
✅ Deploy Preview for analog-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for analog-blog ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for analog-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for analog-ng-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
afa916c
to
7a5bcc7
Compare
One question I had was for the vite-env.d.ts in the ng-app project, do we want to remove the *.analog TS module since this is just a test app or would *.analog files potentially still be added that aren't SFCs? /// <reference types="vite/client" />
...
- declare module '*.analog' {
- const cmp = any;
- export default cmp;
- }
declare module '*.ag' {
const cmp = any;
export default cmp;
} |
7a5bcc7
to
a7cfea9
Compare
It's fine to remove it in the test app.
|
b98085d
to
2dc2b2e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! @allcontributors add @nickytonline for code |
PR Checklist
Closes #1371
What is the new behavior?
Ports all *.analog files in the ng-app project to the *.ag file extension. It also updates imports to use *.ag instead of *.analog now.
Does this PR introduce a breaking change?
I'm thinking the new file extension is a breaking change, but I leave that up to the core team to decide.
Other information
[optional] What gif best describes this PR or how it makes you feel?