Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrated ng-app from .analog to .ag extension #1456

Merged
merged 2 commits into from
Nov 23, 2024

Conversation

nickytonline
Copy link
Contributor

@nickytonline nickytonline commented Nov 22, 2024

PR Checklist

Closes #1371

What is the new behavior?

Ports all *.analog files in the ng-app project to the *.ag file extension. It also updates imports to use *.ag instead of *.analog now.

Does this PR introduce a breaking change?

  • Yes
  • No

I'm thinking the new file extension is a breaking change, but I leave that up to the core team to decide.

Other information

[optional] What gif best describes this PR or how it makes you feel?

Copy link

netlify bot commented Nov 22, 2024

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit 2dc2b2e
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/674113feaa21e600082e01f0
😎 Deploy Preview https://deploy-preview-1456--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 22, 2024

Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit 2dc2b2e
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/674113fe043fa300087b25fc
😎 Deploy Preview https://deploy-preview-1456--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 22, 2024

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit 2dc2b2e
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/674113fe4cd71e0008d02292
😎 Deploy Preview https://deploy-preview-1456--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 22, 2024

Deploy Preview for analog-ng-app ready!

Name Link
🔨 Latest commit 2dc2b2e
🔍 Latest deploy log https://app.netlify.com/sites/analog-ng-app/deploys/674113fe47475d000807846f
😎 Deploy Preview https://deploy-preview-1456--analog-ng-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nickytonline
Copy link
Contributor Author

nickytonline commented Nov 22, 2024

One question I had was for the vite-env.d.ts in the ng-app project, do we want to remove the *.analog TS module since this is just a test app or would *.analog files potentially still be added that aren't SFCs?

/// <reference types="vite/client" />

...

- declare module '*.analog' {
-   const cmp = any;
-   export default cmp;
- }

declare module '*.ag' {
  const cmp = any;
  export default cmp;
}

@brandonroberts
Copy link
Member

It's fine to remove it in the test app.

One question I had was for the vite-env.d.ts in the ng-app project, do we want to remove the *.analog TS module since this is just a test app or would *.analog files potentially still be added that aren't SFCs?

/// <reference types="vite/client" />

...

- declare module '*.analog' {
-   const cmp = any;
-   export default cmp;
- }

declare module '*.ag' {
  const cmp = any;
  export default cmp;
}

Copy link
Member

@brandonroberts brandonroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brandonroberts brandonroberts merged commit 8ab7b62 into analogjs:beta Nov 23, 2024
24 checks passed
@brandonroberts
Copy link
Member

Thanks! @allcontributors add @nickytonline for code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repo: Update Analog SFC app to use .ag extension instead of .analog extension by default
2 participants