Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ivar trim -f option incompatible with new piping functionality #157

Closed
wm75 opened this issue Feb 27, 2023 · 3 comments
Closed

ivar trim -f option incompatible with new piping functionality #157

wm75 opened this issue Feb 27, 2023 · 3 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@wm75
Copy link

wm75 commented Feb 27, 2023

With v1.4 ivar trim can write SAM to stdout, but when the -f option is in use the amplicon interval tree will still print itself to stdout, too

void IntervalTree::inOrder(ITNode *root){
if (root == NULL) return;
inOrder(root->left);
cout << "[" << root->data->low << ", " << root->data->high << "]"
<< " max = " << root->max << endl;
inOrder(root->right);
}

, making those two functionalities incompatible for the moment.

@cmaceves cmaceves self-assigned this Feb 27, 2023
@cmaceves
Copy link
Collaborator

thanks for brining this to my attention, we'll try and get it sorted out before it launches on bioconda!

@wm75
Copy link
Author

wm75 commented Feb 27, 2023

Well, that happened already, so it'll require a new release.

@cmaceves
Copy link
Collaborator

Yeah I just realized that... It'll have to be on our next version bump.

@cmaceves cmaceves added this to the 1.4.1 milestone Feb 27, 2023
@cmaceves cmaceves added the bug Something isn't working label Feb 27, 2023
gkarthik added a commit that referenced this issue Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

2 participants