Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolate quality trimming #35

Closed
gkarthik opened this issue Apr 13, 2020 · 4 comments
Closed

Isolate quality trimming #35

gkarthik opened this issue Apr 13, 2020 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@gkarthik
Copy link
Member

For item 1 in broadinstitute/viral-pipelines#28

@gkarthik gkarthik added the enhancement New feature or request label Apr 13, 2020
@gkarthik gkarthik self-assigned this Apr 13, 2020
@dpark01
Copy link

dpark01 commented Apr 14, 2020

I think the cleanest approach (from a UI perspective) would simply be to make -b an optional parameter for ivar trim, and leave all else the same.

@tseemann
Copy link

This seems dangerous to me.
Forget an option and it doesn't do what the tool is actually mostly designed for?

@dpark01
Copy link

dpark01 commented Apr 19, 2020

This command actually does two things: one was previously required and one was previously optional, and now they are both optional. But maybe that's an argument for splitting them into two commands? (trimprimers, trimquality). Does the new samtools command do everything -b does in ivar trim now?

@gkarthik
Copy link
Member Author

@dpark01 I think the new samtools command in development is intended to do what ivar trim does with the primer trimming. Not sure if they want to port more of the functionality.

@tseemann I add a line to the log stating that without the BED file all the reads regardless of primers were written to file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

3 participants