fix: Improve join time of included fields by using a map instead of a Array.find #246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@andersondanilo, would you be able to review this? 🙏 |
|
🤜 @andersondanilo bumping again |
andersondanilo
force-pushed
the
master
branch
2 times, most recently
from
34c6274 to
ca494e0
Compare
andersondanilo
changed the title
github-actions bot
pushed a commit
that referenced
this pull request
Sep 30, 2025
## [2.3.2](v2.3.1...v2.3.2) (2025-09-30) ### Bug Fixes * Improve join time of included fields by using a map instead of a Array.find ([#246](#246)) ([6b2aabb](6b2aabb))
|
🎉 This PR is included in version 2.3.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Nice! thank for your contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have large responses (e.g. 30k+ entities with 15k+ included values), then deserialization can take 3s+.
This is primarily due to the following line causing us to have an O(n) lookup - leading to an overall O(n^2) deserialization time:
By putting all of our
includedfields into an object keyed by type and then id, we can drop deserialization time from 3s+ to ~100ms for large responses like the one mentioned above.