Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.
This repository was archived by the owner on May 29, 2019. It is now read-only.

Fix and harmonize title display in the tabs and accordion #43

@pkozlowski-opensource

Description

@pkozlowski-opensource

As of today tabs and accordion got the same title attribute but those attributes are interpreted differently:

  • in tabs: scope: { title: '@' }
  • in accordion: scope:{ title:'=' }

I believe that both directives should use the same syntax and I would vote for @. The problem is that it doesn't work in 1.0.2, we should migrate to 1.0.3 but 1.0.3 might have another regression...

In any case the tabs are broken in 1.0.2 at the moment.

Also, we should consider renaming the title attribute due to: #24

Thoughts?

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions