This repository was archived by the owner on May 29, 2019. It is now read-only.
chore(jshint): make JSHint configuration stricter #2861
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Check for usage of undefined variables - Add basic Jasmine globals so that spec files pass JSHint - Ensure that angular variable can't be re-defined (set to false)
- Use $log instead of console as it's safer and always defined - JSHint thinks usage of alert is possibly development code, so use $window.alert instead
chrisirhc
force-pushed
the
feature/make-jshint-stricter
branch
from
cd35f90 to
76d6ebd
Compare
|
Awesome! LGTM, feel free to merge @chrisirhc ! |
ulle
pushed a commit
to ulle/bootstrap
that referenced
this pull request
Oct 22, 2014
- Check for usage of undefined variables - Add basic Jasmine globals so that spec files pass JSHint - Ensure that angular variable can't be re-defined (set to false) Closes angular-ui#2861
OronNadiv
pushed a commit
to lanetix/bootstrap
that referenced
this pull request
Nov 18, 2014
- Check for usage of undefined variables - Add basic Jasmine globals so that spec files pass JSHint - Ensure that angular variable can't be re-defined (set to false) Closes angular-ui#2861
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for usage of undefined variables.
Adding all the Jasmine globals to the JSHint globals is potentially dangerous (since it won't warn if any of them are used in the module code) so later on I intend to move all the *.spec.js files into a test/ directory later and use a separate .jshintrc for that folder.