`removeSelected` removes any pre-selected item from dropdown

[fiznool]

Bug description:

When linking the ui-select component to a model which points to an item in the items array, the preselected item is not displayed in the dropdown list.

Link to minimally-working plunker that reproduces the issue:

http://plnkr.co/edit/bMlvGYc0Jfq3PX8NQcpv?p=preview

Notice that although 'Amalie' is preselected, she is not displayed in the dropdown list.

Version of Angular, UI-Select, and Bootstrap/Select2/Selectize CSS

Angular: 1.5.0

UI-Select: 0.18.0

Bootstrap/Select2/Selectize CSS (if applicable): 3.1.1

[fiznool]

It's worth noting that this situation works fine with 0.17.1.

A temporary fix is to add a remove-selected="false" attribute to the <ui-select> tag.

[p10]

I think it's not a bug but feature ;-) 3ad084f

You can switch it back to false globaly in configuration section:

app.config(function(uiSelectConfig) {
  uiSelectConfig.removeSelected = false;
});

[fiznool]

@p10 I tried this but it didn't work... I think the config block is run after the uiSelectController is created, and so this code which caches the removeSelected flag is still true.

[user378230]

/cc @dondi any chance you could take a look at this?

[dondi]

OK I'll investigate.

[dondi]

Quick update: I have been able to replicate this behavior and have written a unit test for it. Based on what I can replicate, the previous version (0.17.1) indeed does not remove the item from the dropdown, but the highlighted item when the dropdown is displayed for the first time does not match the pre-selected object either (initial highlighted item is always the first one).

Is that what others saw in the previous release? If this is the behavior that everyone is used to, then even if it is not entirely correct, it will be useful to know that just reverting to this will suffice. However if I’m not seeing the correct prior behavior, or if the preference is to get this working completely right, then that changes the code trajectory a bit.

Please advise—thanks!

[fiznool]

From my point of view, I've upgraded from 0.14.1 where the preselected item was correctly displayed and highlighted, my vote would be to revert to this expected behaviour. Thanks!

[dondi]

OK, potential fix available at #1690 …I toggled between master and this to make sure that the incorrect behavior reported here was definitely gone in the new version. All unit tests still pass, plus one more unit test was added specifically for this situation. Hope this does the trick, let me know :)

[dondi]

BTW @fiznool I was able to get this PR to implement the fully correct behavior where the pre-existing selection in the model is indeed highlighted from the get-go in the ui-select element. Thank you!

[mharmuth]

@p10 For me, it works when changing the value to false in configuration. Thanks ;)