This repository was archived by the owner on Oct 2, 2019. It is now read-only.
fix(select2): hide dropdown if there are no items to show #1598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there actually a dropdown displayed? I switched plunkr in #1588 to select2 theme and I didn't see anything that looked wrong. Can you add a screenshot & plunkr demo of the issue? (And possibly one with your fix?) |
|
@user378230 Please have a look at the following (plunker)[http://plnkr.co/edit/42MxM2XbLiANgr0qPO1K?p=preview] This might be a side affect of #1588 |
|
Sorry I was looking at select2 single mode when the problem was in select2 multiple mode. This looks ok then, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is equivalent to #1588 for bootstrap
the empty dropdown behaviour was especially annoying when using ui-select for tagging without choices.