Fix lint

Author: Anatoly Ostrovsky

@types/shared/hof.d.ts

@@ -104,6 +104,5 @@ export function pattern(struct: any): (arg0: any) => any;
  */
 export const propEq: any;
 export function parse(name: any): any;
-export function all(fn1: any): (arr: any) => any;
 export function is(ctor: any): (obj: any) => boolean;
 export function val(v: any): () => any;

src/core/parse/parse.spec.js

@@ -1787,37 +1787,36 @@ describe("parser", () => {
       });
 
       [0, false, "", NaN].forEach((falsyValue) => {
-        "should not overwrite $prop scope properties when assigning",
-          () => {
-            let scope;
-
-            scope = { a: falsyValue, c: falsyValue };
-            tryParseAndIgnoreException("a.b = 1");
-            tryParseAndIgnoreException('c["d"] = 2');
-            expect(scope).toEqual({ a: falsyValue, c: falsyValue });
-
-            scope = { a: { b: falsyValue, c: falsyValue } };
-            tryParseAndIgnoreException("a.b.c = 1");
-            tryParseAndIgnoreException('a.c["d"] = 2');
-            expect(scope).toEqual({ a: { b: falsyValue, c: falsyValue } });
-
-            // Helpers
-            //
-            // Normally assigning property on a primitive should throw exception in strict mode
-            // and silently fail in non-strict mode, IE seems to always have the non-strict-mode behavior,
-            // so if we try to use 'expect(() => {$parse('a.b=1')({a:false});).toThrow()' for testing
-            // the test will fail in case of IE because it will not throw exception, and if we just use
-            // '$parse('a.b=1')({a:false})' the test will fail because it will throw exception in case of Chrome
-            // so we use tryParseAndIgnoreException helper to catch the exception silently for all cases.
-            //
-            function tryParseAndIgnoreException(expression) {
-              try {
-                $parse(expression)(scope);
-              } catch (error) {
-                /* ignore exception */
-              }
+        it("should not overwrite $prop scope properties when assigning", () => {
+          let scope;
+
+          scope = { a: falsyValue, c: falsyValue };
+          tryParseAndIgnoreException("a.b = 1");
+          tryParseAndIgnoreException('c["d"] = 2');
+          expect(scope).toEqual({ a: falsyValue, c: falsyValue });
+
+          scope = { a: { b: falsyValue, c: falsyValue } };
+          tryParseAndIgnoreException("a.b.c = 1");
+          tryParseAndIgnoreException('a.c["d"] = 2');
+          expect(scope).toEqual({ a: { b: falsyValue, c: falsyValue } });
+
+          // Helpers
+          //
+          // Normally assigning property on a primitive should throw exception in strict mode
+          // and silently fail in non-strict mode, IE seems to always have the non-strict-mode behavior,
+          // so if we try to use 'expect(() => {$parse('a.b=1')({a:false});).toThrow()' for testing
+          // the test will fail in case of IE because it will not throw exception, and if we just use
+          // '$parse('a.b=1')({a:false})' the test will fail because it will throw exception in case of Chrome
+          // so we use tryParseAndIgnoreException helper to catch the exception silently for all cases.
+          //
+          function tryParseAndIgnoreException(expression) {
+            try {
+              $parse(expression)(scope);
+            } catch (error) {
+              /* ignore exception */
             }
-          };
+          }
+        });
       });
     });
 

src/directive/events/event.spec.js

@@ -60,13 +60,13 @@ describe("event directives", () => {
     });
 
     it("should expose event on form submit", () => {
-      (app.innerHTML =
+      app.innerHTML =
         '<form ng-submit="formSubmission($event)">' +
         '<input type="submit" />' +
-        "</form>"),
-        window.angular.bootstrap(app, ["myModule"]).invoke((_$rootScope_) => {
-          $rootScope = _$rootScope_;
-        });
+        "</form>";
+      window.angular.bootstrap(app, ["myModule"]).invoke((_$rootScope_) => {
+        $rootScope = _$rootScope_;
+      });
       element = app.querySelector("form");
       $rootScope.formSubmission = function (e) {
         if (e) {

src/directive/repeat/repeat.js

@@ -85,7 +85,7 @@ export function ngRepeatDirective($animate) {
     transclude: "element",
     priority: 1000,
     terminal: true,
-    compile: ($element, $attr) => {
+    compile: (_$element, $attr) => {
       const expression = $attr["ngRepeat"];
       const hasAnimate = !!$attr["animate"];
 

src/router/template-factory.spec.js

@@ -78,9 +78,9 @@ describe("templateFactory", () => {
       ]);
       $injector.invoke(
         (_$templateFactory_, _$httpBackend_, _$sce_, $rootScope) => {
-          ($templateFactory = _$templateFactory_),
-            ($httpBackend = _$httpBackend_),
-            ($sce = _$sce_);
+          $templateFactory = _$templateFactory_;
+          $httpBackend = _$httpBackend_;
+          $sce = _$sce_;
           $scope = $rootScope;
         },
       );
@@ -119,9 +119,9 @@ describe("templateFactory", () => {
           _$state_,
           _$compile_,
         ) => {
-          ($templateFactory = _$templateFactory_),
-            ($httpBackend = _$httpBackend_),
-            ($sce = _$sce_);
+          $templateFactory = _$templateFactory_;
+          $httpBackend = _$httpBackend_;
+          $sce = _$sce_;
           $scope = $rootScope;
           $stateRegistry = _$stateRegistry_;
           $stateService = _$state_;

src/shared/common.js

@@ -1,5 +1,5 @@
 import { isDate, isFunction, isRegExp, isString } from "./utils.js";
-import { all, curry } from "./hof.js";
+import { curry } from "./hof.js";
 
 export function equals(o1, o2) {
   if (o1 === o2) return true;
@@ -9,10 +9,10 @@ export function equals(o1, o2) {
     t2 = typeof o2;
   if (t1 !== t2 || t1 !== "object") return false;
   const tup = [o1, o2];
-  if (all(Array.isArray)(tup)) return _arraysEq(o1, o2);
-  if (all(isDate)(tup)) return o1.getTime() === o2.getTime();
-  if (all(isRegExp)(tup)) return o1.toString() === o2.toString();
-  if (all(isFunction)(tup)) return true; // meh
+  if (tup.every(Array.isArray)) return _arraysEq(o1, o2);
+  if (tup.every(isDate)) return o1.getTime() === o2.getTime();
+  if (tup.every(isRegExp)) return o1.toString() === o2.toString();
+  if (tup.every(isFunction)) return true; // meh
   if ([isFunction, Array.isArray, isDate, isRegExp].some((fn) => !!fn(tup))) {
     return false;
   }

src/shared/hof.js

@@ -96,13 +96,6 @@ export const parse = (name) =>
     name.split(".").map((name) => (obj) => obj && obj[name]),
   );
 
-/**
- * Check if all the elements of an array match a predicate function
- *
- * @param fn1 a predicate function `fn1`
- * @returns a function which takes an array and returns true if `fn1` is true for all elements of the array
- */
-export const all = (fn1) => (arr) => arr.reduce((b, x) => b && !!fn1(x), true);
 /** Given a class, returns a Predicate function that returns true if the object is of that class */
 export const is = (ctor) => (obj) =>
   (obj != null && obj.constructor === ctor) || obj instanceof ctor;