Skip to content

ng test should accept customized config parameter of karma.config.js #12305

@datanglibai

Description

@datanglibai

Bug Report or Feature Request (mark with an x)


- [x] feature request

Command (mark with an x)


- [x] test

Versions

node v8.10.0
npm 5.6.0
@angular/cli 6.1.3

Repro steps

After upgrade to angular 6, the parameter set for the config of karma.config.js does not work anymore
it's NOT the parameter to specify which file, our script is like this

npm run test -- --customizedParam=paramValue

In the karma.config.js, the parameter is used.
module.exports = function (config) {
var customizedParam= config.customizedParam;
......
}

the npm run test is ng test in package.json
this parameter value is decided in build agent, and everytime is different.

The log given by the failure

Unknown option: '--customizedParam'
and it stopped the test run

Desired functionality

the command line parameters for karma config can be accepted as before
or a workaround.
angular 5 cli will also prompt warning message but it didn't stop test and the parameter take effect.

Mention any other details that might be useful

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions