Skip to content

Conversation

alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Feb 16, 2019

… set in app.component.ts and in angular.json

Fixes #13689

@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Feb 16, 2019
@alan-agius4 alan-agius4 requested review from clydin and removed request for filipesilva February 16, 2019 18:04
@kekel87
Copy link

kekel87 commented Feb 17, 2019

I think it should also add the option in the angular.json file :

"schematics": {
  "@schematics/angular:component": {
    "viewEncapsulation": "ShadowDom"
  }
},

For other generated components.

@alan-agius4
Copy link
Collaborator Author

@kekel87, yeah make sense.

@alan-agius4
Copy link
Collaborator Author

@clydin, or should we set defaultEncapsulation inside the main.ts?

@clydin
Copy link
Member

clydin commented Feb 17, 2019

At the application level, I think it would make more sense as a bootstrap option

@kyliau kyliau merged commit 8979790 into angular:master Feb 19, 2019
cexbrayat added a commit to cexbrayat/angular-cli that referenced this pull request Feb 22, 2019
mgechev pushed a commit that referenced this pull request Feb 22, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ng new --viewEncapsulation Native|None|ShadowDom do nothing
5 participants