Skip to content

Conversation

cexbrayat
Copy link
Member

@cexbrayat cexbrayat commented Feb 22, 2019

This was introduced by #13690

Previously to this commit, a trailing comma was always added after styles/styleUrls
The viewEncapsulation also adds one, so there is an extra one.

Fixes: #13742

@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Feb 22, 2019
@alan-agius4
Copy link
Collaborator

Thinking about this, we should probably remove ViewEncapsulation from this file. Inc the import.

Since now we set the defaultViewEncapsulation in main.ts

@cexbrayat
Copy link
Member Author

@alan-agius4 Sure. I updated the PR

Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@mgechev mgechev merged commit 58bc5b8 into angular:master Feb 22, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ng new --viewEncapsulation Native|None|ShadowDom generates invalid code
4 participants