Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v8.0.4 : "module": "esnext", "moduleResolution": "node" appear twice in tsconfig.json #14882

Closed
mpalourdio opened this issue Jun 25, 2019 · 2 comments
Closed

v8.0.4 : "module": "esnext", "moduleResolution": "node" appear twice in tsconfig.json #14882

mpalourdio opened this issue Jun 25, 2019 · 2 comments
Labels
area: schematics/angular freq3: high severity5: regression type: bug/fix
Milestone
8.0.x

Comments

@mpalourdio
Copy link

🐞 Bug report

Command (mark with an x)

- [x] new
- [ ] build
- [ ] serve
- [ ] test
- [ ] e2e
- [ ] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Is this a regression?

yes

Description

From version 8.0.4 and this commit, the generated tsconfig.json contains twice

"module": "esnext",  
"moduleResolution": "node",

🔬 Minimal Reproduction

ng new newproject
@mpalourdio mpalourdio changed the title v8.0.44 : "module": "esnext", "moduleResolution": "node" appear twice in tsconfig.json v8.0.4 : "module": "esnext", "moduleResolution": "node" appear twice in tsconfig.json Jun 25, 2019
@mpalourdio mpalourdio mentioned this issue Jun 25, 2019
Closed
@mpalourdio
Copy link
Author

PR against branch v8.0.x

@ngbot ngbot bot modified the milestones: needsTriage, Backlog Jun 25, 2019
@mpalourdio mpalourdio mentioned this issue Jun 25, 2019
Merged
mpalourdio added a commit to mpalourdio/angular-cli that referenced this issue Jun 25, 2019
@mpalourdio
fix(@schematics/angular): remove duplicate module and moduleResolutio…
2bed79f 
…n properties from tsconfig

Fixes angular#14882
@alan-agius4 alan-agius4 modified the milestones: Backlog, 8.0.x Jun 25, 2019
vikerman pushed a commit that referenced this issue Jun 25, 2019
@mpalourdio @vikerman
fix(@schematics/angular): remove duplicate module and moduleResolutio…
d55e98e 
…n properties from tsconfig

Fixes #14882
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area: schematics/angular freq3: high severity5: regression type: bug/fix
Projects
None yet
Milestone
8.0.x
Development

Successfully merging a pull request may close this issue.

Remove duplicate module and moduleResolution entries mpalourdio/angular-cli
2 participants
@mpalourdio @alan-agius4