Permission error on second build when nomodule polyfill is included

[karptonite]

🐞 Bug report

Command (mark with an x)

- [ ] new
- [x] build
- [ ] serve
- [ ] test
- [ ] e2e
- [ ] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Is this a regression?

I'm not sure. This is the first time I've seen it, but I recently upgraded to Angular 8.

Description

I reproducibly get a permission error, seen below, in a clean, brand new angular project, when browserslist specifies browsers that require nomodule polyfill.

🔬 Minimal Reproduction

1. ng new test
2. In the new project, add to browserslist: ios_saf >= 10
3. ng build --prod
4. ng build --prod (again)

🔥 Exception or Error

chunk {0} runtime-es2015.24b02acc1f369d9b9f37.js (runtime) 2.83 kB [entry] [rendered]
chunk {1} main-es2015.7c221f45d48105c2ba9d.js (main) 251 kB [initial] [rendered]
chunk {2} polyfills-es2015.fd917e7c3ed57f282ee5.js (polyfills) 64.3 kB [initial] [rendered]
chunk {3} polyfills-es5-es2015.3aa54d3e5134f5b5b842.js (polyfills-es5) 223 kB [initial] [rendered]
chunk {4} styles.3ff695c00d717f2d2a11.css (styles) 0 bytes [initial] [rendered]
chunk {polyfills-nomodule-es5} polyfills-nomodule-es5.b79bfebc521ac1ea1602.js (polyfills-nomodule-es5) 372 bytes [entry] [rendered]
Date: 2019-08-30T21:28:19.886Z - Hash: c40b7c3c8a049ad41deb - Time: 12280ms
Generating ES5 bundles for differential loading...
An unhandled exception occurred: EACCES: permission denied, copyfile '/Users/karp/Documents/git/outputhashing2/node_modules/.cache/angular-build-dl/content-v2/sha512/f3/26/48b77841506560fd29c0954a8fe431f253a24b4306fd7399aaec8a09d0dcc974a357856c0b742e8e40a0ac34f406ebc3b58955f738ea327fc8e1819cd7a3' -> '/Users/karp/Documents/git/outputhashing2/dist/outputhashing2/polyfills-nomodule-es5.b79bfebc521ac1ea1602.js'
See "/private/var/folders/pf/z4z5f17x7jb0n0m44bmkhyw00000gn/T/ng-7tYGDL/angular-errors.log" for further details.

🌍 Your Environment

Angular CLI: 8.3.2
Node: 10.16.0
OS: darwin x64
Angular: 8.2.4
... animations, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.803.2
@angular-devkit/build-angular     0.803.2
@angular-devkit/build-optimizer   0.803.2
@angular-devkit/build-webpack     0.803.2
@angular-devkit/core              8.3.2
@angular-devkit/schematics        8.3.2
@angular/cli                      8.3.2
@ngtools/webpack                  8.3.2
@schematics/angular               8.3.2
@schematics/update                0.803.2
rxjs                              6.4.0
typescript                        3.5.3
webpack                           4.39.2

Anything else relevant?
Nuking node_module (and presumably just the cache dir within) and reinstalling fixes the issue for one build.
Sorry to put this out there on a Friday afternoon!

[alan-agius4]

Some other users also seem to experience An unhandled exception occurred: EEXIST: file already exists, copyfile

[karptonite]

According to the other issue, this may happen even without the change to browserslist. I thought the problem popped up when I made that change, but I could easily have missed that.

[alan-agius4]

Yeah, the issue is not related to the browserslist file per see, it's related to a change in 8.3.

[julianpoemp]

I had the same problem and after removing node_modules and npm install it works as it should be.

[chtisgit]

I get this error:

An unhandled exception occurred: EACCES: permission denied, copyfile '/home/christian/projects/test/node_modules/.cache/angular-build-dl/content-v2/sha512/a9/aa/c96f81fde2bc334f1b8e2b015df4c8a584a2c6ba48340a9f4c61cb9d5d3462764f4d023cac89edbdfe7197a1afb211a7d5b2166196daeef021af40d4fcc7' -> '/home/christian/projects/test/dist/test/assets/js/bootstrap.min.js'

The problem is fixed by PR #15512, but many of the generated files are now world-writable (see below). Deploying these files could be less secure than before.

I know nothing about the internal workings of an angular build, but it looks like files are cached and later copied to 'dist'. The files in the cache already have their mode reset to 0o444. Wouldn't it be possible to save the file there with the correct permissions?

If not I would advocate for a less open mode of 0o664 or 0o644.

Nonetheless, thank you for looking into this issue.

Before #15512

-rw-rw-r-- 1 christian christian  15K Sep  4 10:31 3rdpartylicenses.txt
drwxrwxr-x 4 christian christian   27 Sep  4 10:31 assets
-rw-rw-r-- 1 christian christian  948 Sep  4 10:31 favicon.ico
-r--r--r-- 1 christian christian 253K Sep  4 10:31 main-es2015.0840fbfe83afb92a9535.js
-r--r--r-- 1 christian christian 288K Sep  4 10:31 main-es5.0840fbfe83afb92a9535.js
-r--r--r-- 1 christian christian  37K Sep  4 10:31 polyfills-es2015.fd917e7c3ed57f282ee5.js
-r--r--r-- 1 christian christian 117K Sep  4 10:31 polyfills-es5.f9fad3ad3c84e6dbdd72.js
-r--r--r-- 1 christian christian 1.5K Sep  4 10:31 runtime-es2015.24b02acc1f369d9b9f37.js
-r--r--r-- 1 christian christian 1.5K Sep  4 10:31 runtime-es5.24b02acc1f369d9b9f37.js
-rw-rw-r-- 1 christian christian    0 Sep  4 10:31 styles.09e2c710755c8867a460.css

After #15512

-rw-rw-r-- 1 christian christian  15K Sep  4 10:36 3rdpartylicenses.txt
drwxrwxr-x 4 christian christian   27 Sep  4 10:36 assets
-rw-rw-r-- 1 christian christian  948 Sep  4 10:36 favicon.ico
-rw-rw-r-- 1 christian christian  924 Sep  4 10:36 index.html
-rw-rw-rw- 1 christian christian 253K Sep  4 10:36 main-es2015.0840fbfe83afb92a9535.js
-rw-rw-rw- 1 christian christian 288K Sep  4 10:36 main-es5.0840fbfe83afb92a9535.js
-rw-rw-rw- 1 christian christian  37K Sep  4 10:36 polyfills-es2015.fd917e7c3ed57f282ee5.js
-rw-rw-rw- 1 christian christian 117K Sep  4 10:36 polyfills-es5.f9fad3ad3c84e6dbdd72.js
-rw-rw-rw- 1 christian christian 1.5K Sep  4 10:36 runtime-es2015.24b02acc1f369d9b9f37.js
-rw-rw-rw- 1 christian christian 1.5K Sep  4 10:36 runtime-es5.24b02acc1f369d9b9f37.js
-rw-rw-r-- 1 christian christian    0 Sep  4 10:36 styles.09e2c710755c8867a460.css