Skip to content

Conversation

josephperrott
Copy link
Member

If no --registry argument is provided when calling to publish
use the Wombat proxy. Additionally, updates the release process
documentation to instruct usage of the Wombat proxy.

@josephperrott josephperrott added area: etc/misc target: patch This PR is targeted for the next patch release labels Apr 6, 2020
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Apr 7, 2020
@ngbot
Copy link

ngbot bot commented Apr 7, 2020

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "ci/angular: size" is failing
    failure status "ci/circleci: e2e-cli" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small NIT

LGTM.

@josephperrott josephperrott force-pushed the wombot-publish branch 2 times, most recently from 99baf6d to 23c589a Compare April 7, 2020 23:45
If no --registry argument is provided when calling to publish
use the Wombat proxy.  Additionally, updates the release process
documentation to instruct usage of the Wombat proxy.
@mgechev mgechev merged commit 98a5cb4 into angular:master Apr 8, 2020
@josephperrott josephperrott deleted the wombot-publish branch April 8, 2020 04:17
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: etc/misc target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants