Skip to content

build: default to wombat proxy for publishing #17406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2020
Merged

build: default to wombat proxy for publishing #17406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 9 additions & 12 deletions docs/process/release.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,21 +119,18 @@ git push upstream && git push upstream --tags

**This can ONLY be done by a Google employee.**

Log in to [NPM](https://npmjs.com/) to the `angular` account in order to
publish. This account is protected by two factor authentication (2FA).
Log in to the Wombat publishing service using your own github and google.com
account to publish. This enforces the loging is done using 2Factor auth.

Run `npm login`:
Run `npm login --registry https://wombat-dressing-room.appspot.com`:

1. For username, use `angular`.
1. For password, use the value stored [here](http://go/ng-npm-pass).
1. For email, use `devops+npm@angular.io`.
1. For two-factor code, you'll need to set up the account.
* Use an authenticator app such as [Google Authenticator](https://play.google.com/store/apps/details?id=com.google.android.apps.authenticator2).
* Add a new account and enter the text key from [here](http://go/ng-npm-2fa).
* The app will start showing two-factor codes, enter one into the
`npm login` prompt.
1. In the new browser tab, the registry app will ask you to connect with GitHub to create a token
1. After connecting with github, you will be redirected to create a token
1. Upon redirect, an auth token is added to your ~/.npmrc for the proxy

Once successfully logged in, it is time to publish.
After closing the tab, you have successfully logged in, it is time to publish.

**NOTE: After publishing, remove the token added to your `~/.npmrc` file to logout.**

### Publishing

Expand Down
6 changes: 3 additions & 3 deletions scripts/publish.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,9 +116,9 @@ export default async function (args: PublishArgs, logger: logging.Logger) {
if (args.tag) {
publishArgs.push('--tag', args.tag);
}
if (args.registry) {
publishArgs.push('--registry', args.registry);
}

// If no registry is provided, the wombat proxy should be used.
publishArgs.push('--registry', args.registry || 'https://wombat-dressing-room.appspot.com');

return _exec('npm', publishArgs, {
cwd: pkg.dist,
Expand Down