Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run npm i with the Sample Schematics Command #17425

Closed
fireflysemantics opened this issue Apr 8, 2020 · 4 comments · Fixed by #18597
Closed

Run npm i with the Sample Schematics Command #17425

fireflysemantics opened this issue Apr 8, 2020 · 4 comments · Fixed by #18597
Labels
freq1: low Only reported by a handful of users who observe it rarely severity2: inconvenient type: bug/fix
Milestone
Backlog

Comments

@fireflysemantics
Copy link

Running:

schematics schematic --name demo

Creates the demo, but we still need to run npm imanually on the project to get the deps.
@alan-agius4 alan-agius4 added freq1: low Only reported by a handful of users who observe it rarely severity2: inconvenient type: bug/fix comp: schematics/schematics labels Apr 9, 2020
@ngbot ngbot bot added this to the Backlog milestone Apr 9, 2020
@Ayudh
Copy link
Contributor

Ayudh commented Apr 13, 2020

@alan-agius4 Can I raise a PR for this?

@alan-agius4
Copy link
Collaborator

@Ayudh, sure.

Ayudh pushed a commit to Ayudh/angular-cli that referenced this issue Aug 22, 2020
fix(@schematics/schematics): run install step with sample schematics
bef6012 
Closes angular#17425
@Ayudh Ayudh mentioned this issue Aug 22, 2020
Merged
Ayudh added a commit to Ayudh/angular-cli that referenced this issue Aug 22, 2020
@Ayudh
fix(@schematics/schematics): run install step with sample schematics
23b590b 
Closes angular#17425
@Ayudh
Copy link
Contributor

Ayudh commented Aug 22, 2020

@alan-agius4 raised a PR for this. #18597

Ayudh added a commit to Ayudh/angular-cli that referenced this issue Aug 25, 2020
@Ayudh
fix(@schematics/schematics): run install step with sample schematics
90112f4 
Closes angular#17425
clydin pushed a commit that referenced this issue Aug 25, 2020
@Ayudh @clydin
fix(@schematics/schematics): run install step with sample schematics
6c0ab83 
Closes #17425
clydin pushed a commit that referenced this issue Aug 26, 2020
@Ayudh @clydin
fix(@schematics/schematics): run install step with sample schematics
e662247 
Closes #17425

(cherry picked from commit 6c0ab83)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
freq1: low Only reported by a handful of users who observe it rarely severity2: inconvenient type: bug/fix
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

fix(@schematics/schematics): run install step with sample schematics Ayudh/angular-cli
4 participants
@Ayudh @alan-agius4 @clydin @fireflysemantics