Exclude directories from "ng xi18n"

[schwitin]

🚀 Feature request

Command (mark with an x)

• new
• build
• serve
• test
• e2e
• generate
• add
• update
• lint
• xi18n
• run
• config
• help
• version
• doc

Description

The tool parses imported third party modules in node_modules folder too and there is no way to exclude directories from parsing. For example:

create an new app
ng new repro-app

install a third party module
npm @ng-bootstrap/ng-bootstrap

import this module in the app.module.ts

import { NgbModule } from '@ng-bootstrap/ng-bootstrap';
...
imports: [
    ...
      NgbModule
  ]
...

run xi18n
ng xi18n --output-path src/locale --i18n-locale=de

look in the generated messages.xlf

<trans-unit id="ngb.alert.close" datatype="html">
	<source>Close</source>
	<context-group purpose="location">
		<context context-type="sourcefile">node_modules/@ng-bootstrap/ng-bootstrap/alert/alert.d.ts</context>
		<context context-type="linenumber">3</context>
	</context-group>
</trans-unit>

As you cas see the file contains translation units from a third party module although we don,t use it in our templates.

Describe the solution you'd like

A command line parameter --exclude=path/one,path/two will solve my problem. Alternatively (or at once) the parameter --include=path/one, path/two will be helpful.

Describe alternatives you've considered

I could postprocess the messages.xlf with a custom tool to remove unwanted translation units.

[filipesilva]

I think this falls within the purview of the extractor itself, so I'll move it to the angular/angular repo where that package is.

[petebacondarwin]

That sounds right. Also we are working on a new i18n extractor that understands $localize calls so we should consider this request in our design of that...

[aslubsky]

Hi, @petebacondarwin is there any ETA for this feature?

[petebacondarwin]

The new standalone extractor binary can already handle this, since you can point it at the compiled JS files that you care about. Using this binary, the proposed approach is to simply compile the application code using ngc, which outputs a single JS file for each TS file. You can then run the extractor over those files using a glob pattern to choose the JS files that you care about. Note that this approach would not extract messages from 3rd party libraries.

We should include this discussion here in the RFC for Ivy Library Distribution: angular/angular#38366.

[aslubsky]

@petebacondarwin Sorry, did you mean xi18n as "new standalone extractor binary" or something else? For xi18n I can't find any way to set glob pattern. It only use Angular CLI project name as input parameter.

[petebacondarwin]

@aslubsky - sorry not to be clearer. There is a new message extractor in @angular/localize. It is currently being integrated into the CLI (and will replace the current ng xi18n implementation). But in the meantime you can access this new extractor via a standalone binary called localize-extract. See angular/angular#32912 (comment) for an example of how you might use it.

[aslubsky]

got it, thanks

[sankumar]

Hi Team, How to exclude node_modules while extract strings in i18n

[petebacondarwin]

Have you tried using the latest pre-release versions of Angular and the CLI (i.e. 10.1.0-rc.0)? I am not sure if the new implementation of ng xi18n ignores node_modules or not. To use the new extractor you need to provide the --ivy flag for now.

[vengababu5]

@petebacondarwin I am using angular 6 version , how can exclude node_modules extract strings in i18n?

[petebacondarwin]

@vengababu5 - I don't think you can in v6.