Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default tab size #4852

Closed
IRCraziestTaxi opened this issue Feb 20, 2017 · 4 comments
Closed

Default tab size #4852

IRCraziestTaxi opened this issue Feb 20, 2017 · 4 comments

Comments

@IRCraziestTaxi
Copy link

In #1252 the request for CLI options or ability to reference .editorconfig for tab size when generating files was largely ignored. The reasoning was fair - too much effort for minimal impact on a matter of style, not functionality.

However, many, many comments were made that 4 spaces is by and large the accepted standard - basically universally accepted. @filipesilva stated that:

"The style guide has no recommendations on tabs vs spaces..."

So why not conform to the undisputed fact that 4 spaces is standard and make 4 spaces the default? I have seen nobody say that 2 spaces is preferred or even that it is not ugly and does not make code hard to read - quite the opposite, in fact.

@filipesilva
Copy link
Contributor

Dupe of #1252.

@IRCraziestTaxi
Copy link
Author

@filipesilva I would argue this is not a duplicate because #1252 regarded not having an option or functionality to change the default tab size. This issue regards changing the tab size altogether.

@filipesilva
Copy link
Contributor

I'm sorry but all there is to be said about this topic has already been said in #1252.

I recognise and understand that different users have different preferences regarding this subject, and that it is annoying to have to reformat after running generators.

The solution to that is not to take switch from one default to the other, it is to offer the option as described in #1252. But as I said on #1252 (comment) that's something to be looked at in v2.0 at best.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants