Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global defaults.styleExt in globalconfig not honored when creating a new project #5009

Closed
Cammisuli opened this issue Feb 25, 2017 · 4 comments
Assignees

Comments

@Cammisuli
Copy link

Setting the global config to have a default style extenstion does not get honored when creating a new application.

I expect that we can set the defaults in the global config and have the cli respect those settings.

OS?

Mac OSX (El Capitan)

Versions.

@angular/cli: 1.0.0-rc.0

Repro steps.

  • Set global config with ng set --global defaults.styleExt=scss
  • Create new application with ng new
  • Notice that the component styles are still css

Note: creating a new application with ng new appname --style=scss still works. Also doing ng set defaults.styleExt=scss works as well.

@Brocco Brocco self-assigned this Feb 26, 2017
@Brocco
Copy link
Contributor

Brocco commented Feb 26, 2017

The fix for this should depend upon the merging of PR #5023

@Brocco
Copy link
Contributor

Brocco commented Mar 2, 2017

The logic for finding the default globally set style extension was resolved in PR #5023

@Brocco Brocco closed this as completed Mar 2, 2017
@Cammisuli
Copy link
Author

I just got the lastest (rc.1) and doing ng new app does not read the defaults.styleExt from the global config. From the mention PR, it looks like everything reads from the local config, and if it's not there, it reads from the global.

Nevertheless, doing new does not read the global config settings. Maybe I'm missing something?

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants