Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preserve-symlinks option not supported with ng test #7081

Closed
Schibum opened this issue Jul 21, 2017 · 3 comments · Fixed by #7598
Closed

preserve-symlinks option not supported with ng test #7081

Schibum opened this issue Jul 21, 2017 · 3 comments · Fixed by #7598
Assignees
Labels
feature Issue that requests a new feature P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@Schibum
Copy link

Schibum commented Jul 21, 2017

Bug Report or Feature Request (mark with an x)

- [ ] bug report -> please search issues before submitting
- [x] feature request

Versions.

@angular/cli: 1.3.0-beta.1
node: 8.2.0
os: darwin x64

Repro steps.

ng build/serve command do support --preserve-symlinks option, while ng test does not:

$ng build --help | grep sym
  --preserve-symlinks (Boolean) (Default: true) Do not use the real path when resolving modules. 
$ng test --help | grep sym
# empty
$ ng test --preserve-symlinks
The option '--preserve-symlinks' is not registered with the test command. Run `ng test --help` for a list of supported options.

Desired functionality.

I think it'd make sense to support symlinked modules in the test command too.
The test command does not include common build options, while serve does:
https://github.com/angular/angular-cli/blob/master/packages/@angular/cli/commands/serve.ts#L33
Not sure if that's intentional for some reason or by mistake.

@filipesilva
Copy link
Contributor

Yeah I agree it should be available there. ng test and ng build/serve/e2e do not share options for historical reasons that are now outdated. So we should make those shared.

@filipesilva filipesilva self-assigned this Jul 31, 2017
@filipesilva filipesilva added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent feature Issue that requests a new feature labels Jul 31, 2017
filipesilva added a commit to filipesilva/angular-cli that referenced this issue Sep 5, 2017
@zackarychapple
Copy link
Contributor

zackarychapple commented Sep 11, 2017

Awesome @filipesilva, will this be in 1.4.2?

dond2clouds pushed a commit to d2clouds/speedray-cli that referenced this issue Apr 23, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature Issue that requests a new feature P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants