bug(commonjs): erroneous ngfactory

[CaerusKaru]

Bug Report or Feature Request (mark with an x)

- [x] bug report
- [ ] feature request

Versions.

@angular/cli: 1.5.0-beta.2
node: 8.6.0
os: darwin x64
@angular/animations: 5.0.0-rc.0
@angular/cdk: 2.0.0-beta.11
@angular/common: 5.0.0-rc.0
@angular/compiler: 5.0.0-rc.0
@angular/core: 5.0.0-rc.0
@angular/forms: 5.0.0-rc.0
@angular/http: 5.0.0-rc.0
@angular/material: 2.0.0-beta.11
@angular/platform-browser: 5.0.0-rc.0
@angular/platform-browser-dynamic: 5.0.0-rc.0
@angular/platform-server: 5.0.0-rc.0
@angular/router: 5.0.0-rc.0
@angular/cli: 1.5.0-beta.2
@angular/compiler-cli: 5.0.0-rc.0
@angular/language-service: 5.0.0-rc.0
typescript: 2.5.3

Repro steps.

1. Clone the sample repo found here
2. Change into the cli directory
3. Run npm install and npm run build:dynamic

To show the second type of error (detailed below):

1. After the steps above, remove MatCardModule from app.module.ts, and remove the reference to <mat-card> in app.component.ts.
2. Run npm run build:dynamic && npm run serve:dynamic (which should succeed this time)
3. Navigate to localhost:4000. Disable JavaScript and reload the page
4. Attempt to navigate to the lazy route, examine the server for the error log

To show the third type of error (detailed below):

1. Re-enable JavaScript on localhost:4000 and reload the page
2. Attempt to navigate to the lazy route, examine the browser console for the error log

The log given by the failure.

ERROR in ./dist/server/main.bundle.js
Module not found: Error: Can't resolve '@angular/material/card/typings/index.ngfactory' in '/Users/main/universal-cli-bug/cli/dist/server'
 @ ./dist/server/main.bundle.js 1:2433-2490
 @ ./prerender.ts

Desired functionality.

AOT compilation needs to work for commonjs bundling where the bundle includes a lazy-loaded module that also includes an external module like Angular Material.

Mention any other details that might be useful.

This is an issue only when the external module is included in a lazy-loaded module. If it's included at the top-level, it works as expected. It also works as expected in cli@1.4.4

[CaerusKaru]

@filipesilva Is there any update on this issue? I feel like 1.5.0 is nearing final and there has been no progress made here.

To add on to symptoms of this issue, adding the bundle-dependencies flag results in a different error:

Error: No NgModule metadata found for '[object Object]'. This error occurs when the server spins up and tries to compile the module with JIT

When running without the flag, the bundle size for the main module is also significantly smaller than it should be (which makes sense, since most of the lazy-loaded content isn't being compiled).

cc @hansl for bundle-dependencies issue

[filipesilva]

@CaerusKaru do you think this is related to #7901 perhaps? It also had to do with lazy modules and #8157 fixed it.

@Brocco can you have a look?

[CaerusKaru]

@filipesilva It's unrelated, the issue persists in RC.3

@Brocco Here's the updated rub, as far as my investigations have gone:

1. The error no longer surfaces during bundling when the module in question is lazy-loaded, but it does surface now when the module is imported at the top level (I've updated the repo above to reflect this)
2. If the top-level import is removed, the build succeeds, but navigating to the lazy-loaded page with the module returns the following error:

TypeError: factory.create is not a function
    at MapSubscriber.project (/Users/main/universal-cli-bug/cli/dist/server.js:132272:51)
    at MapSubscriber._next (/Users/main/universal-cli-bug/cli/dist/server.js:135287:35)
    at MapSubscriber.Subscriber.next (/Users/main/universal-cli-bug/cli/dist/server.js:26375:18)
    at /Users/main/universal-cli-bug/cli/dist/server.js:109872:36
    at ZoneDelegate.invoke (/Users/main/universal-cli-bug/cli/dist/server.js:123046:26)
    at Object.onInvoke (/Users/main/universal-cli-bug/cli/dist/server.js:5080:33)
    at ZoneDelegate.invoke (/Users/main/universal-cli-bug/cli/dist/server.js:123045:32)
    at Zone.run (/Users/main/universal-cli-bug/cli/dist/server.js:122796:43)
    at /Users/main/universal-cli-bug/cli/dist/server.js:123527:57
    at ZoneDelegate.invokeTask (/Users/main/universal-cli-bug/cli/dist/server.js:123079:31)
    at resolvePromise (/Users/main/universal-cli-bug/cli/dist/server.js:123478:31)
    at resolvePromise (/Users/main/universal-cli-bug/cli/dist/server.js:123449:17)
    at /Users/main/universal-cli-bug/cli/dist/server.js:123527:17
    at ZoneDelegate.invokeTask (/Users/main/universal-cli-bug/cli/dist/server.js:123079:31)
    at Object.onInvokeTask (/Users/main/universal-cli-bug/cli/dist/server.js:5071:33)
    at ZoneDelegate.invokeTask (/Users/main/universal-cli-bug/cli/dist/server.js:123078:36)
    at Zone.runTask (/Users/main/universal-cli-bug/cli/dist/server.js:122846:47)
    at drainMicroTaskQueue (/Users/main/universal-cli-bug/cli/dist/server.js:123256:35)
    at ZoneTask.invokeTask (/Users/main/universal-cli-bug/cli/dist/server.js:123157:21)
    at Server.ZoneTask.invoke (/Users/main/universal-cli-bug/cli/dist/server.js:123142:48)

I'm hoping this is a simple module resolution issue, because it's incredibly frustrating.

[filipesilva]

@MarkPieszak @Toxicable do you have any insight maybe?

[hansl]

Some sub issues should be fixed with #8188

[MarkPieszak]

I haven't seen this one yet, but i'll take a look!

[CaerusKaru]

@hansl I installed cli-builds with #8188, but now the build doesn't respect tsconfig paths specified as follows:

"paths": {
  "@app/*": ["app/*"],
  "@env/*": ["environments/*"]
}

Additionally, the server build is still not built correctly (without the paths)

[CaerusKaru]

ng serve --aot issues fixed by #8188, deleted above comment.

[CaerusKaru]

#8188 also fixes the ng build --prod issues for the browser build, but the server build is still busted.

[vikerman]

Can reproduce the server issue with Angular rc.6 and CLI 1.5 RC.3 and universal-starter repo.

LAZY_MODULE_MAP generated inside the server bundle has reference to the Module instead of the NgModuleFactory - causing factory.create to be undefined.