Error on ng serve rebuild with v1.5.0-beta.4 and --aot

[ocombe]

Bug Report or Feature Request

- [x] bug report

When using ng serve --aot with 1.5.0-beta.4 and Angular 5.0.0-rc.1 it will sometimes print an error message in the shell after rebuilding, but the application still works and is refreshed in the browser. I don't have this error with JIT.

Versions.

@angular/cli: 1.5.0-beta.4
node: 6.9.5
os: win32 x64
@angular/animations: 5.0.0-rc.1
@angular/common: 5.0.0-rc.1
@angular/compiler: 5.0.0-rc.1
@angular/core: 5.0.0-rc.1
@angular/http: 5.0.0-rc.1
@angular/platform-browser: 5.0.0-rc.1
@angular/platform-browser-dynamic: 5.0.0-rc.1
@angular/router: 5.0.0-rc.1
@angular/cli: 1.5.0-beta.4
@angular/compiler-cli: 5.0.0-rc.1
@angular/language-service: 5.0.0-rc.1
@angular/platform-server: 5.0.0-rc.1
typescript: 2.4.2

Repro steps.

git clone -b 3.0 https://github.com/ocombe/subnode.git
npm install
npm start

edit src/app/app.component.ts template, save (it should work), edit again, save, you should see the error in your shell (if not, edit again and save again)

The log given by the failure.

webpack: Compiling...
Date: 2017-10-10T09:14:38.659Z
Hash: cac66266cec51e8840c8
Time: 233ms
chunk {inline} inline.bundle.js, inline.bundle.js.map (inline) 5.83 kB [entry]
chunk {main} main.bundle.js, main.bundle.js.map (main) 22.2 kB {vendor} [initial] [rendered]
chunk {polyfills} polyfills.bundle.js, polyfills.bundle.js.map (polyfills) 217 kB {inline} [initial]
chunk {styles} styles.bundle.js, styles.bundle.js.map (styles) 11.6 kB {inline} [initial]
chunk {vendor} vendor.bundle.js, vendor.bundle.js.map (vendor) 1.37 MB [initial]

webpack: Compiled successfully.
ERROR in Error: Cannot determine the module for class AppComponent in C:/www/subnode/src/app/app.component.ts! Add AppComponent to the NgModule to fix it.

Desired functionality.

It should not print an error message (especially since the app works fine and is recompiled successfully)

[cexbrayat]

Still happening in 1.5.0-rc.0 with ng 5.0.0-rc.2.
I just wanted to add that it also breaks the AoT compilation (errors in template are not detected anymore when the error shows up, which happens very often).

[filipesilva]

@cexbrayat is the error you get the same? Have you noticed any pattern to when the error happens?

This seems related to the forked type checker. Something breaks in that separate process and it seems like type checking stops happening.

[cexbrayat]

Yes, I see the same one as Olivier, in the file I'm editing (PonyComponent):

webpack: Compiling...
 11% building modules 1/1 modules 0 activeERROR in Error: Cannot determine the module for class PonyComponent in /Users/cedric/Code/ninjasquad/ng2-ponyracer/frontend/src/app/pony/pony.component.ts! Add PonyComponent to the NgModule to fix it.

But I also see another quite often:

webpack: Compiling...
 10% building modules 1/1 modules 0 activeCould not resolve module '@angular/core' relative to file undefined
/Users/cedric/Code/ninjasquad/ng2-ponyracer/frontend/node_modules/@angular/compiler/bundles/compiler.umd.js:31549
            throw error;
            ^

TypeError: Cannot read property 'replace' of undefined
    at TsCompilerAotCompilerTypeCheckHostAdapter.resolveModuleName (/Users/cedric/Code/ninjasquad/ng2-ponyracer/frontend/node_modules/@angular/compiler-cli/src/transformers/compiler_host.js:99:65)
    at TsCompilerAotCompilerTypeCheckHostAdapter.moduleNameToFileName (/Users/cedric/Code/ninjasquad/ng2-ponyracer/frontend/node_modules/@angular/compiler-cli/src/transformers/compiler_host.js:133:29)
    at StaticSymbolResolver.resolveModule (/Users/cedric/Code/ninjasquad/ng2-ponyracer/frontend/node_modules/@angular/compiler/bundles/compiler.umd.js:31619:30)
    at StaticSymbolResolver.getSymbolByModule (/Users/cedric/Code/ninjasquad/ng2-ponyracer/frontend/node_modules/@angular/compiler/bundles/compiler.umd.js:31600:46)
    at StaticReflector.findDeclaration (/Users/cedric/Code/ninjasquad/ng2-ponyracer/frontend/node_modules/@angular/compiler/bundles/compiler.umd.js:30069:63)
    at StaticReflector.initializeConversionMap (/Users/cedric/Code/ninjasquad/ng2-ponyracer/frontend/node_modules/@angular/compiler/bundles/compiler.umd.js:30334:36)
    at new StaticReflector (/Users/cedric/Code/ninjasquad/ng2-ponyracer/frontend/node_modules/@angular/compiler/bundles/compiler.umd.js:30019:14)
    at Object.createAotCompiler (/Users/cedric/Code/ninjasquad/ng2-ponyracer/frontend/node_modules/@angular/compiler/bundles/compiler.umd.js:31842:44)
    at AngularCompilerProgram._createProgramWithBasicStubs (/Users/cedric/Code/ninjasquad/ng2-ponyracer/frontend/node_modules/@angular/compiler-cli/src/transformers/program.js:500:37)
    at AngularCompilerProgram.initSync (/Users/cedric/Code/ninjasquad/ng2-ponyracer/frontend/node_modules/@angular/compiler-cli/src/transformers/program.js:474:23)

Pretty much always reproducible in my case: edit a template, add anything, save.

When it happens, the next save will trigger this error:

ERROR in Error [ERR_IPC_CHANNEL_CLOSED]: channel closed
    at ChildProcess.target.send (internal/child_process.js:590:16)
    at AngularCompilerPlugin._updateForkedTypeChecker (/Users/cedric/Code/ninjasquad/ng2-ponyracer/frontend/node_modules/@ngtools/webpack/src/angular_compiler_plugin.js:339:34)
    at AngularCompilerPlugin._createOrUpdateProgram (/Users/cedric/Code/ninjasquad/ng2-ponyracer/frontend/node_modules/@ngtools/webpack/src/angular_compiler_plugin.js:219:18)
    at Promise.resolve.then.then (/Users/cedric/Code/ninjasquad/ng2-ponyracer/frontend/node_modules/@ngtools/webpack/src/angular_compiler_plugin.js:505:29)
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:188:7)

which is fatal (a edit/save will not retrigger the compilation).

[ocombe]

You can use this repository as well to help with the debug: https://github.com/ocombe/i18n-demo-no-cli
The issue always happens on each rebuild, for JIT and AOT.
This project only uses @ngtools webpack plugins, not the whole cli.