fix(@ngtools/webpack): fix bootstrapping code #8188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansl
force-pushed
the
lazy-module-fix
branch
from
ebb2483 to
c7dec0e
Compare
filipesilva
previously approved these changes
Oct 25, 2017
filipesilva
previously approved these changes
Oct 25, 2017
There is no link between a new identifier and its import (and apparently TS does not export any API to make one in the type checker). The best way to import a symbol reliably is to use a namespace import (import * as x from "abc"). The new bootstrapping code uses just that.
hansl
force-pushed
the
lazy-module-fix
branch
4 times, most recently
from
fc80809 to
4b41515
Compare
With support for the new API, we stopped processing lazy routes paths, which was a mistake
hansl
force-pushed
the
lazy-module-fix
branch
from
4b41515 to
771979b
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no link between a new identifier and its import (and apparently TS does
not export any API to make one in the type checker). The best way to import a
symbol reliably is to use a namespace import (import * as x from "abc").
The new bootstrapping code uses just that.