Skip to content

fix(@angular/cli): handle raw strings in config command #10956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2018

Conversation

clydin
Copy link
Member

@clydin clydin commented May 22, 2018

Fixes: #10949

@filipesilva filipesilva merged commit 4e53bfd into angular:master May 24, 2018
@clydin clydin deleted the fix-config branch May 24, 2018 18:02
@sannminwin
Copy link

sannminwin commented Aug 24, 2018

It seems errors still exist

@angular/cli 6.0.8

I added styleExt: scss in angular.json

"projects": {
"staff-directory": {
"root": "",
"sourceRoot": "src",
"projectType": "application",
"prefix": "app",
"schematics": {
"@schematics/angular:component": {
"styleExt": "scss"
}
},

I changed every "css" to "scss" in angular.json

"styles": [
"src/styles.scss"
],

I changed header.component.css to "scss" . When I run "ng serve" , I got this error

ERROR in ./src/app/app.component.ts
Module not found: Error: Can't resolve './app.component.css' in '/Sites/angular/staff-directory/src/app'
ERROR in ./src/app/regions/header/header.component.ts
Module not found: Error: Can't resolve './header.component.css' in '/Sites/angular/staff-directory/src/app/regions/header'

@clydin
Copy link
Member Author

clydin commented Aug 24, 2018

@sannminwin Please do not reply to closed PRs.
Also, what you are describing is not related to the PR in question. If you suspect you have encountered a defect, please open an issue and include the requested information within the template.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing default styleExt to scss gives me Value cannot be found
4 participants