Skip to content

Conversation

delasteve
Copy link
Contributor

@delasteve delasteve commented Jun 17, 2016

Eventually will fix #1093

Route generation checklist:

  • Recreate ng generate route
  • Create ng generate guard and spec file
  • Create app.routes.ts boilerplate
  • Export ./app.routes in app barrel
  • Import and bootstrap APP_ROUTER_PROVIDERS
  • Create blueprint for routes file
  • Allow --lazy to be set
  • Allow custom --path to be set
  • Modify parent {component}.routes.ts

If I am missing anything, please let me know and I will add it to the list.

@nxpatterns
Copy link

thank you, it works for me:

$ ng generate route test
installing route
installing component
  create src\app\+test\test.component.css
  create src\app\+test\test.component.html
  create src\app\+test\test.component.spec.ts
  create src\app\+test\test.component.ts
  create src\app\+test\index.ts
  create src\app\+test\shared\index.ts

would you update the main repository, would be great,..

@jasonswett
Copy link

Dumb question, but how do I try out this new version? I tried doing npm install -g git+ssh://git@github.com:delasteve/angular-cli.git\#feature/router-v3 but it didn't seem to work.

@nxpatterns
Copy link

the changes are not merged yet, I've edited the source codes manually,..

@delasteve delasteve force-pushed the feature/router-v3 branch from d0da43d to ed577bb Compare June 17, 2016 12:45
@filipesilva
Copy link
Contributor

I'd like to add a caveat to this PR: we're still waiting on some initial style guide recommendations about how routes should look like with the new router, and that will eventually determine how generation ends up working/looking like.

@delasteve
Copy link
Contributor Author

Totally agree and understood. See the conundrum I got myself into. 😝

@delasteve delasteve force-pushed the feature/router-v3 branch from ed577bb to f5c2ea3 Compare July 8, 2016 02:55
@hansl
Copy link
Contributor

hansl commented Jul 8, 2016

We already have someone internally working on making ng generate route works properly again. The project is limited to route configuration, and does not include guards. I'm going to put this PR on hold until we re-enable route generation and then we can discuss more about adding guards to the project as a new feature.

Cheers!

@delasteve delasteve force-pushed the feature/router-v3 branch from f5c2ea3 to 7b720ae Compare July 26, 2016 10:45
@Brocco
Copy link
Contributor

Brocco commented Oct 14, 2016

Routes have changed drastically and currently there are no plans to generate specific routes, only routing module files.

@Brocco Brocco closed this Oct 14, 2016
@delasteve delasteve deleted the feature/router-v3 branch January 17, 2017 06:32
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Due to changes in the router, route generation has been temporarily disabled.
7 participants