Skip to content

Conversation

clydin
Copy link
Member

@clydin clydin commented Sep 10, 2018

…deprecated

Fixes: #12230

@hansl
Copy link
Contributor

hansl commented Sep 10, 2018

Does this PR include a way to upgrade people doing a new project today (with 6.2.x)?

@clydin
Copy link
Member Author

clydin commented Sep 11, 2018

No. This one handles the conversion: #12234

Scratch that. It is now included here.

@clydin clydin force-pushed the targets branch 2 times, most recently from a81476b to c15e5a5 Compare September 12, 2018 00:17
@hansl
Copy link
Contributor

hansl commented Sep 12, 2018

Last nit; we should create a test to have targets and read it using architect to validate that the reading logic works. Otherwise LGTM

@clydin clydin added target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Sep 13, 2018
@kyliau kyliau merged commit 9e7391c into angular:master Sep 13, 2018
@clydin clydin deleted the targets branch September 13, 2018 23:47
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ng-add schematics broken in 6.2 (e.g. @angular/material)
4 participants