Skip to content

docs(@angular/cli): correct e2e long description field #12561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2018

Conversation

clydin
Copy link
Member

@clydin clydin commented Oct 11, 2018

No description provided.

@filipesilva
Copy link
Contributor

Related to #12554.

Copy link
Contributor

@filipesilva filipesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: can you change it to e2e-long.md to match the existing ones?

@clydin
Copy link
Member Author

clydin commented Oct 11, 2018

There's actually two of each format in there. so I picked the shorter form.

@filipesilva
Copy link
Contributor

Oh you're right, I didn't notice the add.md. Nevermind my request then.

@clydin
Copy link
Member Author

clydin commented Oct 11, 2018

Too late :). It makes more sense anyway since there could also be e2e-usage.md for usage notes.

@ngbot
Copy link

ngbot bot commented Oct 11, 2018

Artifact Baseline Current Change
cli/new-production/test-project/main.js 169.01KB 169.11KB +104 bytes

@filipesilva filipesilva added the target: major This PR is targeted for the next major release label Oct 11, 2018
@angular angular deleted a comment from ngbot bot Oct 11, 2018
@vikerman vikerman merged commit 0ae8475 into angular:master Oct 11, 2018
@clydin clydin deleted the fix-docs branch October 11, 2018 17:41
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants