fix(@schematics/angular): --minimal should prevent generating e2e #12742
Conversation
|
@noelmace, thanks for this. I think adding a test would definitely be beneficial, even to avoid possible regressions in the future. |
| @@ -368,7 +368,7 @@ export default function (options: ApplicationOptions): Rule { | |||
| }), | |||
| move(sourceDir), | |||
| ]), MergeStrategy.Overwrite), | |||
| schematic('e2e', e2eOptions), | |||
| !options.minimal ? schematic('e2e', e2eOptions) : noop(), | |||
There was a problem hiding this comment.
can you invert the logic and remove the negation?
There was a problem hiding this comment.
Sure! I tough it was a kind of convention to use noop as "else" 😅
alan-agius4
added
target: patch
|
@noelmace Could you please rebase and fix the conflicts? |
|
Hi @noelmace! This PR has merge conflicts due to recent upstream merges. |
Don't run the e2e schematic when using application or ng-new schematics with option.minimal set to true. fix angular#12739
alexeagle
force-pushed
the
fix-minimal-e2e
branch
from
b2893f1
to
62a8490
Compare
|
I rebased it and force-pushed to your branch |
…2742) * fix(@schematics/angular): --minimal should prevent generating e2e Don't run the e2e schematic when using application or ng-new schematics with option.minimal set to true. fix #12739 * style: inverse logic according to feedback * test(@schematics/angular): app and ng-new --minimal shouldn't generate e2e
|
Thx @alexeagle for the rebase, I didn'ts saw it soon enough. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Don't run the e2e schematic when using application or ng-new schematics
with option.minimal set to true.
fix #12739
Couldn't test it works with ng new, let me know if I should write a test for that.