fix(@schematics/angular): update @angular-devkit/build-ng-packagr w…
#12768
Conversation
alan-agius4
added
the
target: patch
alan-agius4
changed the title
@angular-devkit/build-ng-packagr w…@angular-devkit/build-ng-packagr w…
| @@ -19,6 +19,11 @@ | |||
| "version": "7.1.0-beta.0", | |||
| "factory": "./update-7/index#typeScriptHelpersRule", | |||
| "description": "Update an Angular CLI project to version 7." | |||
| }, | |||
| "migration-05": { | |||
| "version": "7.0.3", | |||
There was a problem hiding this comment.
Yesterday we were talking about not adding migrations on minors/patch versions, so I'm not sure if we should add this one.
There was a problem hiding this comment.
In that case maybe I should add it as 7.1.0-beta.0, what do you reckon?
There was a problem hiding this comment.
I think this is really fixing a deficiency in the 7.0 update process. So it would make sense to have it in a 7.0 patch release so that anyone updating from earlier majors will immediately benefit.
There was a problem hiding this comment.
So the logic is that newly updated projects (6->7) will include this migration, but that we don't expect users to run update from 7->7 and to get it, right? I'm ok with that.
|
Hi @alan-agius4! This PR has merge conflicts due to recent upstream merges. |
1 similar comment
|
Hi @alan-agius4! This PR has merge conflicts due to recent upstream merges. |
…hen migrating Closes #12642
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
…hen migrating
Closes #12642