Skip to content

build: add external block for tsconfig in test targets #12879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2018
Merged

build: add external block for tsconfig in test targets #12879

merged 1 commit into from
Nov 6, 2018

Conversation

kyliau
Copy link
Contributor

@kyliau kyliau commented Nov 6, 2018

internal ts_library rule does not require tsconfig attribute.

@vikerman vikerman merged commit db78228 into angular:master Nov 6, 2018
@kyliau kyliau added the target: patch This PR is targeted for the next patch release label Nov 6, 2018
@kyliau kyliau deleted the tsconfig branch November 6, 2018 19:12
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@vikerman vikerman vikerman approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@vikerman vikerman

Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kyliau @vikerman @googlebot