Skip to content

feat(@schematics/angular): generate ngsw-config.json under the project #13346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 8, 2019
Merged

feat(@schematics/angular): generate ngsw-config.json under the project #13346

merged 1 commit into from
Jan 8, 2019

Conversation

alan-agius4
Copy link
Collaborator

Generate ngsw-config.json under the project sourceRoot if root is empty similar to the karma.conf.js

Now:

-- src
---- ngsw-config.json
-- project
---- app
------ ngsw-config.json

Current:

-- ngsw-config.json
-- src
-- project
---- app
------ ngsw-config.json

Fixes #10793

Generate `ngsw-config.json` under the project sourceRoot if root is empty similar to the `karma.conf.js`

Now:
```
-- src
---- ngsw-config.json
-- project
---- app
------ ngsw-config.json
```
Current:
```
-- ngsw-config.json
-- src
-- project
---- app
------ ngsw-config.json
```

Fixes #10793
@alan-agius4 alan-agius4 reopened this Jan 2, 2019
@alan-agius4 alan-agius4 added the target: major This PR is targeted for the next major release label Jan 2, 2019
@alan-agius4 alan-agius4 added target: major This PR is targeted for the next major release and removed target: major This PR is targeted for the next major release labels Jan 2, 2019
@alexeagle alexeagle merged commit 263e8c1 into angular:master Jan 8, 2019
@alan-agius4 alan-agius4 deleted the ngsw-path branch January 8, 2019 21:50
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Path to ngsw-config.json
4 participants