feat(@schematics/angular): add type checking for protractor.conf.js file #13957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
requested changes
Mar 21, 2019
There was a problem hiding this comment.
Thanks @doggy8088 for this.
Can you kindly fix your commit message to:
feat(@schematics/angular): add type checking for protractor.conf.js file
Fixes #13958
And also rebase?
|
@alan-agius4 done. |
alan-agius4
approved these changes
Mar 22, 2019
|
@dobbydog, thanks for your contribution. |
alan-agius4
added
the
target: major
|
@alan-agius4 I think you tagged the wrong person. 😅 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add type checking for protractor.conf.js file make edit this file more easily.
related to #13958