feat(@angular-devkit/schematics): Add registerCollection to Schematic… #14835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sTestRunner Fixes #14833
…sTestRunner Fixes #14833
kyliau
reviewed
Jun 19, 2019
There was a problem hiding this comment.
LGTM.
I think another way to make SchematicTestRunner more composable is by making the constructor take a NodeModulesEngineHost as an optional third parameter.
That way, external collections could be registered outside of the class without additional public method that forwards the call.
clydin
approved these changes
Jun 20, 2019
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…sTestRunner
Fixes #14833