feat(@angular/cli): implement deploy command #15105

mgechev · 2019-07-17T21:39:35Z

Implementation of the ng deploy command. Find the design document here.

// cc @vikerman @StephenFluin @clydin @alan-agius4 @filipesilva

packages/angular/cli/commands/deploy-impl.ts

StephenFluin · 2019-07-18T22:36:20Z

I think including the folks that we worked directly with for the initial launch would be fair. Otherwise we could say "cloud providers of x size/revenue/users".

…

On Thu, Jul 18, 2019 at 3:22 PM Minko Gechev ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In packages/angular/cli/commands/deploy-impl.ts <#15105 (comment)>: > + * @license + * Copyright Google Inc. All Rights Reserved. + * + * Use of this source code is governed by an MIT-style license that can be + * found in the LICENSE file at https://angular.io/license + */ +import { ArchitectCommand, ArchitectCommandOptions } from '../models/architect-command'; +import { Arguments } from '../models/interface'; +import { Schema as DeployCommandSchema } from './deploy'; + +export class DeployCommand extends ArchitectCommand<DeployCommandSchema> { + public readonly target = 'deploy'; + public readonly error = `Cannot find "deploy" target for the specified project. + +You can find a package that implements deployment capabilities for your +favorite platform on npm: https://www.npmjs.com/search?q=ng%20deploy What would be the recommendation criteria? We don't have first party deployment builders. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#15105?email_source=notifications&email_token=AABIJQEI6QYFMSEYX5N62ODQADUI3A5CNFSM4IEUYW72YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB65VXVI#discussion_r305138216>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABIJQCJFNVMJGDIINW5DADQADUI3ANCNFSM4IEUYW7Q> .

filipesilva

Just some initial requests about the commits themselves. I don't have access to the design doc yet.

filipesilva · 2019-07-19T14:48:42Z

scripts/validate-user-analytics.ts

@@ -26,6 +26,7 @@ const metricsTableRe = /<!--METRICS_TABLE_BEGIN-->([\s\S]*)<!--METRICS_TABLE_END
 function _exec(command: string, args: string[], opts: { cwd?: string }, logger: logging.Logger) {
  const { status, error, stdout } = spawnSync(command, args, {
    stdio: ['ignore', 'pipe', 'inherit'],
+    maxBuffer: 1024 * 1024,


This change should be in it's own commit.

Yesterday I was looking at a similar problem in e4e04e2 and now I know that 1024 * 1024 is actually the default.

Is this change actually doing something? I guess only if maxBuffer was being passed as a smaller value in opts but I don't find maxBuffer referenced anywhere in scripts.

Looks like a leftover, just removed it.

packages/angular_devkit/build_angular/src/deploy/index.ts

packages/angular_devkit/build_angular/builders.json

packages/angular_devkit/build_angular/src/deploy/index.ts

packages/angular/cli/models/architect-command.ts

filipesilva

Just a couple questions and minor requests, otherwise LGTM.

filipesilva · 2019-07-30T09:04:40Z

scripts/validate-user-analytics.ts

@@ -26,6 +26,7 @@ const metricsTableRe = /<!--METRICS_TABLE_BEGIN-->([\s\S]*)<!--METRICS_TABLE_END
 function _exec(command: string, args: string[], opts: { cwd?: string }, logger: logging.Logger) {
  const { status, error, stdout } = spawnSync(command, args, {
    stdio: ['ignore', 'pipe', 'inherit'],
+    maxBuffer: 1024 * 1024,


Yesterday I was looking at a similar problem in e4e04e2 and now I know that 1024 * 1024 is actually the default.

Is this change actually doing something? I guess only if maxBuffer was being passed as a smaller value in opts but I don't find maxBuffer referenced anywhere in scripts.

filipesilva · 2019-07-30T09:05:53Z

packages/angular/cli/commands/deploy.json

+{
+  "$schema": "http://json-schema.org/schema",
+  "$id": "ng-cli://commands/deploy.json",
+  "description": "Invokes the deploy builder for a specified project. If no project is specified, the CLI will invoke the deploy builder for the default project in thw workspace.",


Nit: thw -> the

filipesilva · 2019-07-30T09:11:48Z

packages/angular/cli/models/architect-command.ts

@@ -74,12 +75,13 @@ export abstract class ArchitectCommand<
      }
    }

-    if (targetProjectNames.length === 0) {
-      throw new Error(`No projects support the '${this.target}' target.`);
+    if (!options.help && (targetProjectNames.length === 0)) {


Why does !options.help need to added to this condition and the one below it? If I call ng deploy --help this still looks like the error that shows up.

Since we don't have a default dummy builder, the command is going to always throw when the user invokes ng deploy --help.

mgechev · 2019-07-30T18:19:49Z

As discussed today, there's some inconsistent behavior in the CLI in handling the --help option.

If we improve it, the implementation of ng deploy would be simpler and more consistent with the rest of the commands. Adding it for further discussion so we can sync on the work breakdown this Thursday :).

angular-automatic-lock-bot · 2019-09-13T06:41:44Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes label Jul 17, 2019

StephenFluin reviewed Jul 18, 2019

View reviewed changes

packages/angular/cli/commands/deploy-impl.ts Outdated Show resolved Hide resolved

mgechev force-pushed the minko/deploy branch 3 times, most recently from 31b1dde to f64e55b Compare July 18, 2019 22:20

mgechev force-pushed the minko/deploy branch 2 times, most recently from 8398e08 to 42b8dde Compare July 18, 2019 23:01

mgechev marked this pull request as ready for review July 18, 2019 23:05

mgechev requested review from clydin and alan-agius4 July 18, 2019 23:06

mgechev added the target: major This PR is targeted for the next major release label Jul 18, 2019

filipesilva suggested changes Jul 19, 2019

View reviewed changes

alan-agius4 reviewed Jul 19, 2019

View reviewed changes

packages/angular_devkit/build_angular/src/deploy/index.ts Outdated Show resolved Hide resolved

mgechev force-pushed the minko/deploy branch 7 times, most recently from 22a2218 to ede7321 Compare July 26, 2019 23:46

clydin requested changes Jul 29, 2019

View reviewed changes

packages/angular/cli/models/architect-command.ts Outdated Show resolved Hide resolved

mgechev force-pushed the minko/deploy branch from ede7321 to e831d90 Compare July 29, 2019 18:49

clydin approved these changes Jul 29, 2019

View reviewed changes

filipesilva suggested changes Jul 30, 2019

View reviewed changes

mgechev force-pushed the minko/deploy branch 3 times, most recently from 0038e7f to c2f50d4 Compare July 30, 2019 17:41

mgechev added the needs: discussion On the agenda for team meeting to determine next steps label Jul 30, 2019

mgechev force-pushed the minko/deploy branch 5 times, most recently from d68992e to ea91049 Compare July 30, 2019 19:21

mgechev removed the needs: discussion On the agenda for team meeting to determine next steps label Jul 30, 2019

feat(@angular/cli): implement deploy command

1f9c0af

mgechev force-pushed the minko/deploy branch from ea91049 to 1f9c0af Compare July 30, 2019 21:26

filipesilva approved these changes Jul 30, 2019

View reviewed changes

vikerman merged commit 5df50ba into angular:master Jul 31, 2019

mgechev deleted the minko/deploy branch July 31, 2019 16:57

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(@angular/cli): implement deploy command #15105

feat(@angular/cli): implement deploy command #15105

mgechev commented Jul 17, 2019 •

edited

StephenFluin commented Jul 18, 2019 via email

filipesilva left a comment

filipesilva Jul 19, 2019

mgechev Jul 20, 2019

filipesilva Jul 30, 2019

mgechev Jul 30, 2019 •

edited

filipesilva left a comment

filipesilva Jul 30, 2019

filipesilva Jul 30, 2019

filipesilva Jul 30, 2019

mgechev Jul 30, 2019

mgechev commented Jul 30, 2019

angular-automatic-lock-bot bot commented Sep 13, 2019

feat(@angular/cli): implement deploy command #15105

feat(@angular/cli): implement deploy command #15105

Conversation

mgechev commented Jul 17, 2019 • edited

StephenFluin commented Jul 18, 2019 via email

filipesilva left a comment

Choose a reason for hiding this comment

filipesilva Jul 19, 2019

Choose a reason for hiding this comment

mgechev Jul 20, 2019

Choose a reason for hiding this comment

filipesilva Jul 30, 2019

Choose a reason for hiding this comment

mgechev Jul 30, 2019 • edited

Choose a reason for hiding this comment

filipesilva left a comment

Choose a reason for hiding this comment

filipesilva Jul 30, 2019

Choose a reason for hiding this comment

filipesilva Jul 30, 2019

Choose a reason for hiding this comment

filipesilva Jul 30, 2019

Choose a reason for hiding this comment

mgechev Jul 30, 2019

Choose a reason for hiding this comment

mgechev commented Jul 30, 2019

angular-automatic-lock-bot bot commented Sep 13, 2019

mgechev commented Jul 17, 2019 •

edited

mgechev Jul 30, 2019 •

edited