fix(@schematics/angular): handle the inlineTemplate case for ng new #15324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the template of `app.component.ts` when using `--inlineTemplate`.
mgechev
force-pushed
the
inline-template
branch
from
fe72bdd to
4fe7577
Compare
alan-agius4
reviewed
Aug 14, 2019
| @@ -4,10 +4,11 @@ import { Component } from '@angular/core'; | |||
| selector: '<%= selector %>',<% if(inlineTemplate) { %> | |||
| template: ` | |||
| <!--The content below is only a placeholder and can be replaced.--> | |||
| <div style="text-align:center"> | |||
| <div style="text-align:center" class="content"> | |||
There was a problem hiding this comment.
Where is this class being declared? Cannot seem to find it outside of the external html file.
There was a problem hiding this comment.
Oh, it's required for the tests to pass.
alan-agius4
approved these changes
Aug 14, 2019
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the template of
app.component.tswhen using--inlineTemplate.