Skip to content

refactor(@angular-devkit/build-angular): update webpack typings #15334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 14, 2019

Conversation

clydin
Copy link
Member

@clydin clydin commented Aug 14, 2019

No description provided.

@clydin clydin added the target: major This PR is targeted for the next major release label Aug 14, 2019
@clydin clydin requested a review from filipesilva August 14, 2019 12:30
@alan-agius4
Copy link
Collaborator

@clydin you beat me to it, I was gonna do it a couple of hrs ago.

Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update

output: {
futureEmitAssets: true,
path: path.resolve(root, buildOptions.outputPath as string),
publicPath: buildOptions.deployUrl,
filename: `[name]${targetInFileName}${hashFormat.chunk}.js`,
// cast required until typings include `futureEmitAssets` property
} as Output,

Should become

    output: {
      futureEmitAssets: true,
      path: path.resolve(root, buildOptions.outputPath),
      publicPath: buildOptions.deployUrl,
      filename: `[name]${targetInFileName}${hashFormat.chunk}.js`,
    },

@clydin clydin force-pushed the update-webpack-types branch from 415ab4b to b3b104a Compare August 14, 2019 15:33
@clydin
Copy link
Member Author

clydin commented Aug 14, 2019

Ah. I missed one. Cast removed.

@mgechev mgechev merged commit 3db2787 into angular:master Aug 14, 2019
@clydin clydin deleted the update-webpack-types branch August 14, 2019 17:26
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants