Skip to content

Conversation

eusen
Copy link
Contributor

@eusen eusen commented Sep 12, 2019

change projects.patternProperties to npm.name.pattern

Closes #14797

@eusen eusen changed the title fix(cli/schema): sublevel names are not supported fix(@angular/cli): support the sublevel names of projects Sep 13, 2019
@alan-agius4
Copy link
Collaborator

Ps: might also require a rebase

@alan-agius4
Copy link
Collaborator

Hi @eusen, are you willing to address the comments please?

@alan-agius4 alan-agius4 self-assigned this Oct 17, 2019
Copy link
Contributor Author

@eusen eusen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Oct 28, 2019
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

change projects.patternProperties to npm.name.pattern

Closes #14797
@vikerman vikerman merged commit 31a35ae into angular:master Oct 28, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scoped library highlighting issue
5 participants