Ivy i18n Localization Improvements #15884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
reviewed
Oct 21, 2019
| executor.stop(); | ||
| } | ||
|
|
||
| context.logger.info(`Localized bundle generation ${hasErrors ? 'failed' : 'complete'}.`); |
There was a problem hiding this comment.
Nit: when failed, we should use .error
alan-agius4
approved these changes
Oct 21, 2019
clydin
force-pushed
the
parallel-i18n
branch
2 times, most recently
from
6880368 to
9f9aee1
Compare
…n-differential builds
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i18nFile/i18nLocale)Fixes #15896