Skip to content

refactor(@schematics/angular): remove hardcoded value of `newProjectR… #15925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2019

Conversation

ahasall
Copy link
Contributor

@ahasall ahasall commented Oct 23, 2019

…oot`

the default value of newProjectRoot is already defined in the schema

…oot`

the default value of `newProjectRoot` is already defined in the schema
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM

@alan-agius4 alan-agius4 added the target: major This PR is targeted for the next major release label Oct 23, 2019
@vikerman vikerman merged commit cc4abdd into angular:master Oct 23, 2019
@ahasall ahasall deleted the patch-ng-new-1 branch November 10, 2019 02:00
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants